Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update hashes for bash versions #42

Merged
merged 3 commits into from
Jul 25, 2022
Merged

Update hashes for bash versions #42

merged 3 commits into from
Jul 25, 2022

Conversation

dav3r
Copy link
Member

@dav3r dav3r commented Jul 22, 2022 •
edited

🗣 Description

This PR updates the known hashes for bash versions on our current production systems.

💭 Motivation and context

As our deployed instances move to newer versions of bash, we want to update their hashes in this repository so that we can be assured that our code is indeed functioning as intended.

🧪 Testing

I verified that these updated hashes are indeed being detected when I scanned our Production instances.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced
    in code comments.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.

✅ Post-merge checklist

  • Add a tag.

@dav3r dav3r added the improvement This issue or pull request will add or improve functionality, maintainability, or ease of use label Jul 22, 2022
@dav3r dav3r requested a review from felddy as a code owner July 22, 2022 17:58
@dav3r dav3r self-assigned this Jul 22, 2022
@dav3r dav3r changed the title Update hashes for bash versions on current production systems Update hashes for bash versions Jul 22, 2022
jsf9k
jsf9k approved these changes Jul 22, 2022
View reviewed changes
Copy link
Member

@jsf9k jsf9k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bash hash!

mcdonnnj
mcdonnnj approved these changes Jul 22, 2022
View reviewed changes
Copy link
Member

@mcdonnnj mcdonnnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. I had one thought that you can feel free to decline.

src/ioc_scan/ioc_scanner.py Show resolved Hide resolved
@dav3r @mcdonnnj
Add known hash for zsh
8925967 
Since zsh is the current Mac default shell, we figured it would be
good to included it here.

Co-authored-by: Nick <50747025+mcdonnnj@users.noreply.github.com>
@dav3r dav3r merged commit 9455a97 into develop Jul 25, 2022
@dav3r dav3r deleted the improvement/update-known-hashes branch July 25, 2022 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsf9k jsf9k jsf9k approved these changes

@mcdonnnj mcdonnnj mcdonnnj approved these changes

@felddy felddy Awaiting requested review from felddy felddy is a code owner

Assignees

@dav3r dav3r

Labels
improvement This issue or pull request will add or improve functionality, maintainability, or ease of use
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dav3r @jsf9k @mcdonnnj