Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve search #47

Merged
merged 3 commits into from
Jun 9, 2023
Merged

Improve search #47

merged 3 commits into from
Jun 9, 2023

Conversation

jsf9k
Copy link
Member

@jsf9k jsf9k commented Jun 6, 2023 •
edited

🗣 Description

This pull request improves the shell command run via aws ssm start-session.

It also fixes an unrelated typo.

💭 Motivation and context

find-grep should be a bit more efficient than the way the search for IoCs was being done before. The old way required one more grep command in the pipe chain.

🧪 Testing

I used these changes to successfully run a search for some IoCs we received recently.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.

jsf9k added 3 commits June 6, 2023 12:40
@jsf9k
Fix typo
e2300e5
@jsf9k
Improve the remote command
82bd257 
* Use find-grep instead of relying on shell globbing.
* Get rid of one of the grep filters by filtering the search in find.
@jsf9k
Improve word wrapping
cd5aa4a
@jsf9k jsf9k added the improvement This issue or pull request will add or improve functionality, maintainability, or ease of use label Jun 6, 2023
@jsf9k jsf9k self-assigned this Jun 6, 2023
@jsf9k jsf9k marked this pull request as ready for review June 6, 2023 19:28
@jsf9k jsf9k requested a review from a team June 6, 2023 19:28
dav3r
dav3r approved these changes Jun 8, 2023
View reviewed changes
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love it! 👍
This should definitely be faster than before.

@jsf9k jsf9k enabled auto-merge June 9, 2023 16:43
felddy
felddy approved these changes Jun 9, 2023
View reviewed changes
Copy link
Member

@felddy felddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lookin' good!

@jsf9k jsf9k merged commit d92c803 into develop Jun 9, 2023
49 checks passed
@jsf9k jsf9k deleted the improvement/improve-search branch June 9, 2023 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felddy felddy felddy approved these changes

@dav3r dav3r dav3r approved these changes

@jasonodoom jasonodoom Awaiting requested review from jasonodoom jasonodoom is a code owner

@mcdonnnj mcdonnnj Awaiting requested review from mcdonnnj mcdonnnj is a code owner

Assignees

@jsf9k jsf9k

Labels
improvement This issue or pull request will add or improve functionality, maintainability, or ease of use
Projects
CyHy System
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jsf9k @felddy @dav3r