Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update hashes for newer versions of bash #51

Merged
merged 2 commits into from
Jul 19, 2023
Merged

Update hashes for newer versions of bash #51

merged 2 commits into from
Jul 19, 2023

Conversation

dav3r
Copy link
Member

@dav3r dav3r commented Jul 19, 2023 •
edited

🗣 Description

This PR simply updates the test (known valid) hashes for the versions of bash found on our current images.

💭 Motivation and context

Just keeping up with the changes. We always want to ensure that our hash scanning process is working as intended.

🧪 Testing

I ran the script and confirmed that these hashes were identified on our instances.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.

✅ Pre-merge checklist

  • Finalize version.

✅ Post-merge checklist

  • Create a release.

@dav3r dav3r added the improvement This issue or pull request will add or improve functionality, maintainability, or ease of use label Jul 19, 2023
@dav3r dav3r self-assigned this Jul 19, 2023
mcdonnnj
mcdonnnj approved these changes Jul 19, 2023
View reviewed changes
Copy link
Member

@mcdonnnj mcdonnnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@dav3r dav3r merged commit f3070c4 into develop Jul 19, 2023
49 checks passed
@dav3r dav3r deleted the improvement/update-known-hashes branch July 19, 2023 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsf9k jsf9k jsf9k approved these changes

@jasonodoom jasonodoom jasonodoom approved these changes

@mcdonnnj mcdonnnj mcdonnnj approved these changes

@felddy felddy Awaiting requested review from felddy felddy is a code owner

Assignees

@dav3r dav3r

Labels
improvement This issue or pull request will add or improve functionality, maintainability, or ease of use
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dav3r @jsf9k @jasonodoom @mcdonnnj