This repository has been archived by the owner on Feb 2, 2023. It is now read-only.
Consistently sort output YAML #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sort the entries in each group of converted entries by vendor and then product. Both are converted to lowercase to create a case-insensitive sort. This will provide the most human-friendly sort.
Update the sort rules in the normalize-yml command to be consistent with the sorting done in the convert-cisagov command. That is to sort by vendor and then product for a human-friendly sorted output.
mcdonnnj
added
the
improvement
Pull Request Test Coverage Report for Build 1725858893
💛 - Coveralls |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
This pr updates the
convert-cisagovcommand to sort thesoftwareentries in the converted Markdown's YAML output by vendor and then product. It also updates the sorting functionality in thenormalize-ymlto sort in the same manner.💭 Motivation and context
This most human-friendly sorting is that which sorts on two values plainly instead of combining them. Since Python allows that with its sorting it is better to switch to that method for output. Just for a consistent experience the initial converted output from
convert-cisagovis updated to be sorted the same way.🧪 Testing
✅ Pre-approval checklist