-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Logging in ManageOperators Class #10
Conversation
The default value does not include an operator for the user value we pass in the logging output call. This results in a TypeError exception because there are more arguments than the format string has operators.
Since "Successfully" was removed to improve readability for the output in ManageOperators._update_cyhy_ops_users(), I have mirrored that change in the rest of the class.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! ⛔ 🐞
Please note my single-character suggestion.
Consistency is key. Co-authored-by: dav3r <david.redmin@trio.dhs.gov>
Further tweak the logging messages to ensure they are consistent in structure and language.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Solid! 🎸
🗣 Description
This PR fixes an issue with a logging message and makes some small edits to improve readability and consistency.
💭 Motivation and context
I was testing a bash script that uses this today and when using the
add
command twice ran into an error with logging output:While fixing that issue I improved the output phrasing and made changes to keep all the logging consistent as a result.
🧪 Testing
Automated testing passes. I verified that the modified version does not exhibit the error mentioned above.
✅ Checklist