New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add Christina to fixtures list #2062
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code-wise this looks great. However, it looks like there is a merge conflict that you'd need to resolve before merging this. Once thats resolved, I can take a quick look over and approve!
Let me know if you need any help on it
🥳 Successfully deployed to developer sandbox ky. |
1 similar comment
🥳 Successfully deployed to developer sandbox ky. |
🥳 Successfully deployed to developer sandbox ky. |
🥳 Successfully deployed to developer sandbox ky. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM -- did a cross comparison with the one Alysia made for Riley recently and looks great!
Quick question: Would Christina want to change the Analyst email to christina.burnett+1@cisa.dhs.gov
, or does @gwe...
send to the same email? (Asking bc I'm not sure if it sends to the same mailbox, which may be easier sometimes for testing)
For some reason the +1 didn't work for her, so we're using the @gwe.cisa.dhs.gov email instead. It doesn't send to the same inbox as the @cisa.dhs.gov one unfortunately |
Ticket
Resolves #2052
Changes
Context for reviewers
Setup
Code Review Verification Steps
As the original developer, I have
Satisfied acceptance criteria and met development standards
Ensured code standards are met (Original Developer)
Validated user-facing changes (if applicable)
As a code reviewer, I have
Reviewed, tested, and left feedback about the changes
Ensured code standards are met (Code reviewer)
Validated user-facing changes as a developer
New pages have been added to .pa11yci file so that they will be tested with our automated accessibility testing
Checked keyboard navigability
Meets all designs and user flows provided by design/product
Tested general usability, landmarks, page header structure, and links with a screen reader (such as Voiceover or ANDI)
Tested with multiple browsers, the suggestion is to use ones that the developer didn't (check off which ones were used)
(Rarely needed) Tested as both an analyst and applicant user
Note: Multiple code reviewers can share the checklists above, a second reviewers should not make a duplicate checklist
As a designer reviewer, I have
Verified that the changes match the design intention
Validated user-facing changes as a designer
Checked keyboard navigability
Tested general usability, landmarks, page header structure, and links with a screen reader (such as Voiceover or ANDI)
Tested with multiple browsers (check off which ones were used)
(Rarely needed) Tested as both an analyst and applicant user
Screenshots