Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump version from 0.1.0-rc.1 to 0.1.0 #12

Merged
merged 1 commit into from
Jun 13, 2022
Merged

Bump version from 0.1.0-rc.1 to 0.1.0 #12

merged 1 commit into from
Jun 13, 2022

Conversation

mcdonnnj
Copy link
Member

@mcdonnnj mcdonnnj commented Jun 13, 2022 •
edited

🗣 Description

I did a dumb thing and forgot to finalize the version in #8 so this remedies that failure.

💭 Motivation and context

We shouldn't have release candidate versions pushed to the primary branch of a repository. Doubly so since this was not intentional.

🧪 Testing

Automated tests pass.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.

✅ Post-merge checklist

  • Add a tag or create a release.

@mcdonnnj mcdonnnj added the bug This issue or pull request addresses broken functionality label Jun 13, 2022
@mcdonnnj mcdonnnj self-assigned this Jun 13, 2022
dav3r
dav3r approved these changes Jun 13, 2022
View reviewed changes
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mcdonnnj mcdonnnj merged commit bdd0e50 into develop Jun 13, 2022
@mcdonnnj mcdonnnj deleted the bug/finalize_version branch June 13, 2022 19:20
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 3cafcea on bug/finalize_version into 93a32f8 on develop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsf9k jsf9k jsf9k approved these changes

@dav3r dav3r dav3r approved these changes

@felddy felddy Awaiting requested review from felddy felddy is a code owner

Assignees

@mcdonnnj mcdonnnj

Labels
bug This issue or pull request addresses broken functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mcdonnnj @coveralls @jsf9k @dav3r