Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add types-PyYAML to requirements-dev #18

Merged
merged 1 commit into from
Feb 17, 2023
Merged

Add types-PyYAML to requirements-dev #18

merged 1 commit into from
Feb 17, 2023

Conversation

jmorrowomni
Copy link
Contributor

@jmorrowomni jmorrowomni commented Feb 17, 2023 •
edited

🗣 Description

Add types-PyYAML to requirements-dev

💭 Motivation and context

During testing it was discovered that types-PyYAML was missing from requirements-dev
causing mypy issues

🧪 Testing

After adding types-PyYAML to requirements-dev.txt, mypy --install-types src/ runs cleanly

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.

@jmorrowomni jmorrowomni added the improvement This issue or pull request will add or improve functionality, maintainability, or ease of use label Feb 17, 2023
@coveralls
Copy link

Coverage Status

Coverage: 100.0%. Remained the same when pulling e181f60 on improvement/update_requirements into 4e6df6e on develop.

@jmorrowomni jmorrowomni merged commit 78833ee into develop Feb 17, 2023
@jmorrowomni jmorrowomni deleted the improvement/update_requirements branch February 17, 2023 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsf9k jsf9k jsf9k approved these changes

@dav3r dav3r dav3r approved these changes

@felddy felddy Awaiting requested review from felddy felddy is a code owner

@mcdonnnj mcdonnnj Awaiting requested review from mcdonnnj mcdonnnj is a code owner

Assignees
No one assigned
Labels
improvement This issue or pull request will add or improve functionality, maintainability, or ease of use
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jmorrowomni @coveralls @jsf9k @dav3r