Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the latest Docker images #127

Merged
merged 9 commits into from
Dec 6, 2022
Merged

Use the latest Docker images #127

merged 9 commits into from
Dec 6, 2022

Conversation

jsf9k
Copy link
Member

@jsf9k jsf9k commented Nov 3, 2022 •
edited
Loading

🗣 Description

This pull request:

  • Modifies the Docker composition to use the latest versions of the Docker images
  • Rearranges the YAML in the Docker composition file so that services and their attributes are alphabetized
  • Adds semver to the Python development requirements since it is necessary to run the script that bumps the version

💭 Motivation and context

The latest Docker images use Python 3.11, which may offer some performance improvements.

🧪 Testing

All automated tests pass.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.

@jsf9k jsf9k added improvement This issue or pull request will add or improve functionality, maintainability, or ease of use version bump This issue or pull request increments the version number labels Nov 3, 2022
@jsf9k jsf9k self-assigned this Nov 3, 2022
@jsf9k jsf9k marked this pull request as ready for review November 3, 2022 17:00
@jsf9k jsf9k force-pushed the improvement/use-latest-docker-images branch from da255ba to 934eb0f Compare December 4, 2022 20:15
@jsf9k jsf9k force-pushed the improvement/use-latest-docker-images branch from 96f8d2c to 0b7277f Compare December 5, 2022 19:12
@jsf9k jsf9k requested a review from dav3r December 5, 2022 22:13
dav3r
dav3r approved these changes Dec 6, 2022
View reviewed changes
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍

mcdonnnj
mcdonnnj approved these changes Dec 6, 2022
View reviewed changes
Copy link
Member

@mcdonnnj mcdonnnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@jsf9k jsf9k merged commit 6b63871 into develop Dec 6, 2022
@jsf9k jsf9k deleted the improvement/use-latest-docker-images branch December 6, 2022 21:56
cisagovbot pushed a commit that referenced this pull request Apr 20, 2023
@jmorrowomni
Merge pull request #127 from cisagov/dependabot/github_actions/action…
847cd13 
…s/setup-go-4

Bump actions/setup-go from 3 to 4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dav3r dav3r dav3r approved these changes

@mcdonnnj mcdonnnj mcdonnnj approved these changes

Assignees

@jsf9k jsf9k

Labels
improvement This issue or pull request will add or improve functionality, maintainability, or ease of use version bump This issue or pull request increments the version number
Projects
CyHy System
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jsf9k @dav3r @mcdonnnj