Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the latest gatherer and scanner Docker images #135

Merged
merged 2 commits into from
Feb 8, 2023
Merged

Use the latest gatherer and scanner Docker images #135

merged 2 commits into from
Feb 8, 2023

Conversation

jsf9k
Copy link
Member

@jsf9k jsf9k commented Feb 6, 2023 •
edited
Loading

🗣 Description

Thispull request modifies the Docker composition to use the latest Docker images from cisagov/gatherer and cisagov/scanner.

💭 Motivation and context

The latest versions of these two Docker images pull in the bugfixes from cisagov/domain-scan#4.

🧪 Testing

All automated tests pass.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.

✅ Post-merge checklist

  • Create a release.

@jsf9k jsf9k added improvement This issue or pull request will add or improve functionality, maintainability, or ease of use version bump This issue or pull request increments the version number labels Feb 6, 2023
@jsf9k jsf9k added this to In progress in BOD 18-01 via automation Feb 6, 2023
@jsf9k jsf9k self-assigned this Feb 6, 2023
@jsf9k jsf9k marked this pull request as ready for review February 6, 2023 16:15
@jsf9k jsf9k requested a review from a team February 6, 2023 16:15
jmorrowomni
jmorrowomni approved these changes Feb 6, 2023
View reviewed changes
Copy link
Contributor

@jmorrowomni jmorrowomni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

BOD 18-01 automation moved this from In progress to Reviewer approved Feb 6, 2023
mcdonnnj
mcdonnnj approved these changes Feb 8, 2023
View reviewed changes
Copy link
Member

@mcdonnnj mcdonnnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@jsf9k jsf9k merged commit 893536e into develop Feb 8, 2023
BOD 18-01 automation moved this from Reviewer approved to Done Feb 8, 2023
@jsf9k jsf9k deleted the improvement/use-latest-gatherer-and-scanner branch February 8, 2023 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dav3r dav3r dav3r approved these changes

@jmorrowomni jmorrowomni jmorrowomni approved these changes

@mcdonnnj mcdonnnj mcdonnnj approved these changes

Assignees

@jsf9k jsf9k

Labels
improvement This issue or pull request will add or improve functionality, maintainability, or ease of use version bump This issue or pull request increments the version number
Projects
BOD 18-01
Status: Done
BOD 18-01
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jsf9k @dav3r @jmorrowomni @mcdonnnj