Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the latest Docker images #138

Merged
merged 2 commits into from
Apr 21, 2023
Merged

Use the latest Docker images #138

merged 2 commits into from
Apr 21, 2023

Conversation

jsf9k
Copy link
Member

@jsf9k jsf9k commented Apr 17, 2023 •
edited
Loading

🗣 Description

This pull request modifies the Docker composition to use the latest Docker images.

💭 Motivation and context

See these pull requests for more details:

🧪 Testing

I performed a full reporting run with these changes and they behaved as expected.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.

✅ Post-merge checklist

  • Create a release.

@jsf9k jsf9k added version bump This issue or pull request increments the version number dependencies Pull requests that update a dependency file labels Apr 17, 2023
@jsf9k jsf9k self-assigned this Apr 17, 2023
@jsf9k jsf9k added this to In progress in BOD 18-01 via automation Apr 17, 2023
@jsf9k jsf9k marked this pull request as ready for review April 17, 2023 20:43
@jsf9k jsf9k requested review from jasonodoom and a team April 17, 2023 20:44
mcdonnnj
mcdonnnj approved these changes Apr 20, 2023
View reviewed changes
Copy link
Member

@mcdonnnj mcdonnnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good but is there a reason that cisagov/saver didn't make the cut?

BOD 18-01 automation moved this from In progress to Reviewer approved Apr 20, 2023
@jsf9k
Copy link
Member Author

jsf9k commented Apr 21, 2023

This all looks good but is there a reason that cisagov/saver didn't make the cut?

cisagov/saver uses the same base Docker image as skeleton-docker, so I was going to wait and let cisagov/skeleton-docker#161 flow down naturally.

@jsf9k jsf9k merged commit 3e47093 into develop Apr 21, 2023
BOD 18-01 automation moved this from Reviewer approved to Done Apr 21, 2023
@jsf9k jsf9k deleted the improvement/latest-docker-images branch April 21, 2023 20:02
cisagovbot pushed a commit that referenced this pull request Sep 13, 2023
@mcdonnnj
Merge pull request #138 from cisagov/add-go-packages
4ec50ab 
Add go packages for pre-commit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dav3r dav3r dav3r approved these changes

@mcdonnnj mcdonnnj mcdonnnj approved these changes

@jasonodoom jasonodoom Awaiting requested review from jasonodoom jasonodoom is a code owner

Assignees

@jsf9k jsf9k

Labels
dependencies Pull requests that update a dependency file version bump This issue or pull request increments the version number
Projects
BOD 18-01
Status: Done
CyHy System
Status: Done
BOD 18-01
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jsf9k @dav3r @mcdonnnj