Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin to specific version (0.0.6) of cisagov/postfix image #37

Merged
merged 2 commits into from
Jan 25, 2022

Conversation

dav3r
Copy link
Member

@dav3r dav3r commented Jan 24, 2022

πŸ—£ Description

This PR pins this composition to the current newest version of cisagov/postfix-docker, which is 0.0.6. Previously, we only used cisagov/postfix:latest.

πŸ’­ Motivation and context

There are two goals here:

  1. Pinning to a specific version moves us toward our goal of more reproducible build processes.
  2. We want to pull in the recent improvement from: Add --force-badname flag to useradd commandΒ postfix-docker#33.

πŸ§ͺ Testing

All automated tests pass.

βœ… Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • All new and existing tests pass.

βœ… Pre-merge checklist

  • Finalize version.

βœ… Post-merge checklist

  • Add a tag or create a release.

@dav3r dav3r added the improvement This issue or pull request will add or improve functionality, maintainability, or ease of use label Jan 24, 2022
@dav3r dav3r self-assigned this Jan 24, 2022
@dav3r dav3r requested a review from mcdonnnj January 24, 2022 22:19
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1742459178

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 0.0%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/gophish_init/_version.py 0 1 0.0%
Totals Coverage Status
Change from base Build 1688469728: 0.0%
Covered Lines: 0
Relevant Lines: 45

πŸ’› - Coveralls

Copy link
Member

@mcdonnnj mcdonnnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the strict pinning!

Copy link
Member

@jsf9k jsf9k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1-2-3 πŸ”” πŸ”” πŸ””

@dav3r dav3r merged commit ee1f240 into develop Jan 25, 2022
@dav3r dav3r deleted the improvement/use-latest-postfix branch January 25, 2022 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement This issue or pull request will add or improve functionality, maintainability, or ease of use
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants