Remove unnecessary quotes around port numbers #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsf9k
added
the
improvement
Pull Request Test Coverage Report for Build 1813221307
💛 - Coveralls |
jsf9k
added a commit
to cisagov/pca-gophish-composition-packer
that referenced
this pull request
Feb 8, 2022
These quotes are no longer necessary (or correct) after cisagov/pca-gophish-composition#38.
9 tasks
mcdonnnj
approved these changes
Feb 8, 2022
jsf9k
added a commit
to cisagov/pca-gophish-composition-packer
that referenced
this pull request
Feb 8, 2022
…composition" This reverts commit 913e9a7. The changes in that non-default branch have been merged into the default branch via cisagov/pca-gophish-composition#38.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
This pull request removes some unnecessary quotes around port numbers.
💭 Motivation and context
These quotes are unnecessary, and they lead to some needlessly complicated regex expressions in cisagov/pca-gophish-composition-packer. This is a sister PR of cisagov/pca-gophish-composition-packer#72, and the two PRs should be merged together.
🧪 Testing
All automated tests pass. I also built a new staging AMI with these changes, deployed it to
env6-staging, and verified that it functions as expected.✅ Pre-approval checklist