Skip to content
This repository has been archived by the owner on Feb 14, 2024. It is now read-only.

Commit

Permalink
Remove unnecessary variable
Browse files Browse the repository at this point in the history
Remove total variable declaration, and add issue url for future TODO
  • Loading branch information
DJensen94 committed Dec 3, 2021
1 parent 538ca59 commit f0fb31e
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions src/pe_reports/metrics.py
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,10 @@ def total(self):
"""Return total number of credentials."""
df_cred_csg = self.query_cyberSix_creds.shape[0]
df_cred_hibp = self.query_hibp_view.shape[0]
total = df_cred_csg + df_cred_hibp
return total
return df_cred_csg + df_cred_hibp

# TODO the following functions correspond to functions at report_generator.py
# TODO and will be added in follow up PR's.
# TODO and will be added in follow up PR found here: https://github.com/cisagov/pe-reports/pull/99
def password(self):
"""Return total number of credentials with passwords."""

Expand Down

0 comments on commit f0fb31e

Please sign in to comment.