This repository has been archived by the owner on Feb 14, 2024. It is now read-only.
DB_Schema update: Data_source table, PSHTT, and combined credential domain alerts tables #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Get rid of any source specific tables and add a datasource column to each
aloftus23
added
the
improvement
Pull Request Test Coverage Report for Build 1964239676
💛 - Coveralls |
aloftus23
changed the title
aloftus23
changed the title
aloftus23
requested review from
dav3r,
felddy,
jsf9k and
mcdonnnj
as code owners
dav3r
approved these changes
Mar 8, 2022
cduhn17
reviewed
Mar 10, 2022
cduhn17
suggested changes
Mar 10, 2022
There was a problem hiding this comment.
@aloftus23
One small adjustment to the column name change at shodan_verified_vulns.
Co-authored-by: cduhn17 <87447403+cduhn17@users.noreply.github.com>
cduhn17
approved these changes
Mar 10, 2022
|
Thank you everyone for your continued diligence and support in moving PR's along! |
aloftus23
pushed a commit
that referenced
this pull request
Apr 5, 2022
DB_Schema update: Data_source table, PSHTT, and combined credential domain alerts tables
aloftus23
pushed a commit
that referenced
this pull request
Apr 15, 2022
DB_Schema update: Data_source table, PSHTT, and combined credential domain alerts tables
aloftus23
pushed a commit
that referenced
this pull request
Apr 27, 2022
DB_Schema update: Data_source table, PSHTT, and combined credential domain alerts tables
cisagovbot
pushed a commit
that referenced
this pull request
Apr 26, 2023
…nd-wheel-with-pip Install/upgrade setuptools and wheel when upgrading pip
cisagovbot
pushed a commit
that referenced
this pull request
Dec 19, 2023
Add support for Python version 3.12 in build workflow
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
Added data_source table and got rid of any source specific tables. For example, added a data_source column to the "credential_exposures" table to specify the source: either cybersix and hibp (instead of a hibp_exposed_credential table)
Added PSHTT table.
fixes #107
fixes #110
💭 Motivation and context
Normalize the db schema.
🧪 Testing
Successfully built the database using this schema.
✅ Pre-approval checklist
in code comments.
to reflect the changes in this PR.