Skip to content
This repository has been archived by the owner on Feb 14, 2024. It is now read-only.

Add Craig Duhn (cduhn17) to CODEOWNERS #25

Merged
merged 1 commit into from
Jul 27, 2021
Merged

Add Craig Duhn (cduhn17) to CODEOWNERS #25

merged 1 commit into from
Jul 27, 2021

Conversation

stewartl97
Copy link
Contributor

@stewartl97 stewartl97 commented Jul 27, 2021 •
edited by jsf9k

🗣 Description

This pull request adds @cduhn17 to the codeowners for this repository.

💭 Motivation and context

@cduhn is a new member of the P&E team.

🧪 Testing

All pre-commit hooks and GitHub Actions pass.

✅ Checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1071492968

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 69.71%
Totals Coverage Status
Change from base Build 1060367599: 0.0%
Covered Lines: 158
Relevant Lines: 225
💛 - Coveralls

@stewartl97 stewartl97 changed the title Adding Craig Duhn (cduhn17) to CODEOE Adding Craig Duhn (cduhn17) to CODEOWNERS Jul 27, 2021
@jsf9k jsf9k self-assigned this Jul 27, 2021
@jsf9k jsf9k added the improvement This issue or pull request will add or improve functionality, maintainability, or ease of use label Jul 27, 2021
@jsf9k jsf9k changed the title Adding Craig Duhn (cduhn17) to CODEOWNERS Add Craig Duhn (cduhn17) to CODEOWNERS Jul 27, 2021
@jsf9k
Copy link
Member

jsf9k commented Jul 27, 2021

Please note that I fleshed out the body of the PR and changed the title to be in the imperative mood. The former is important because it allows us to search for relevant PRs later when investigating issues.

felddy
felddy approved these changes Jul 27, 2021
View reviewed changes
Copy link
Member

@felddy felddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome aboard! :shipit:

@jsf9k jsf9k merged commit bf53303 into develop Jul 27, 2021
@jsf9k jsf9k deleted the stewartl97-patch-1 branch July 27, 2021 14:48
@schmelz21 schmelz21 mentioned this pull request Jul 27, 2021
Closed
2 tasks
aloftus23 pushed a commit that referenced this pull request Apr 13, 2022
@jsf9k
Merge pull request #25 from cisagov/stewartl97-patch-1
214a321 
Add Craig Duhn (cduhn17) to CODEOWNERS
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@felddy felddy felddy approved these changes

@jsf9k jsf9k jsf9k approved these changes

@dav3r dav3r Awaiting requested review from dav3r dav3r is a code owner

@mcdonnnj mcdonnnj Awaiting requested review from mcdonnnj mcdonnnj is a code owner

Assignees

@jsf9k jsf9k

Labels
improvement This issue or pull request will add or improve functionality, maintainability, or ease of use
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@stewartl97 @coveralls @jsf9k @felddy