Skip to content
This repository has been archived by the owner on Feb 14, 2024. It is now read-only.

Update Reports to include TLP:AMber markings #311

Merged
merged 5 commits into from
Jan 9, 2023
Merged

Conversation

aloftus23
Copy link
Contributor

@aloftus23 aloftus23 commented Oct 26, 2022

fixes #310

🗣 Description

Adds the TLP:AMBER flag to the mailer and style.css was updated to conform to the template changes. *The HTML templates are not uploaded to GitHub, but can be requested by reaching out to a P&E team member.

💭 Motivation and context

Follows the CISA TLP Guidelines.

🧪 Testing

Passes pre-commit and pytests.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced
    in code comments.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

@aloftus23 aloftus23 self-assigned this Oct 26, 2022
@cduhn17 cduhn17 marked this pull request as ready for review December 30, 2022 16:40
@dav3r
Copy link
Member

dav3r commented Dec 30, 2022

I'm not sure if you are aware of this or if you planned to do it later, but either way I wanted to mention/remind that we don't review PRs until all of the items in the "Pre-approval checklist" have either been checked or removed (if they don't apply to this PR).

@coveralls
Copy link

coveralls commented Dec 30, 2022

Coverage Status

Coverage: 25.555%. Remained the same when pulling e4a123f on AL-add-tlpAmber into d3d7439 on develop.

Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍

Copy link
Collaborator

@cduhn17 cduhn17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@cduhn17 cduhn17 merged commit 31f8630 into develop Jan 9, 2023
@cduhn17 cduhn17 deleted the AL-add-tlpAmber branch January 9, 2023 13:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Reports to include TLP:AMber markings
4 participants