Skip to content
This repository has been archived by the owner on Feb 14, 2024. It is now read-only.

Add credential exposure tables and adjust foreign keys #47

Merged
merged 1 commit into from
Sep 3, 2021

Conversation

DJensen94
Copy link
Contributor

@DJensen94 DJensen94 commented Sep 2, 2021

Added data models for the postgres database for the different hibp and cybersix exposure sources. Also updated direction of the relationships in dns tables to point the correct direction
fixes #38

💭 Motivation and context

• This change is required to get the initial database configuration set up to model the data we are pulling from our various APIs that we will then use when generating our reports.
• This solves our problem of not having a model/ or location to store the data we need for our report

🧪 Testing

passes pre-commits and pytest

✅ Checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced
    in code comments.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

Added data models for the postgres database for the different hibp and cybersix exposure sources. Also updated direction of the relationships in dns tables
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1194454233

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 69.583%

Totals Coverage Status
Change from base Build 1174855813: 0.0%
Covered Lines: 157
Relevant Lines: 224

💛 - Coveralls

@aloftus23 aloftus23 self-requested a review September 2, 2021 19:00
@DJensen94 DJensen94 marked this pull request as ready for review September 2, 2021 19:11
@aloftus23 aloftus23 marked this pull request as draft September 2, 2021 19:12
Copy link
Collaborator

@schmelz21 schmelz21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@schmelz21 schmelz21 added the documentation This issue or pull request improves or adds to documentation label Sep 2, 2021
@schmelz21
Copy link
Collaborator

@DJensen94 , @aloftus23 make sure to add in assignee, labels, links and projects when creating PR.. makes it traceable the more we build out here.

@DJensen94 DJensen94 marked this pull request as ready for review September 2, 2021 20:00
Copy link
Collaborator

@cduhn17 cduhn17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This schema looks good.

@schmelz21 schmelz21 merged commit b5816ec into develop Sep 3, 2021
@schmelz21 schmelz21 deleted the dj-working-sql branch September 3, 2021 14:13
@schmelz21 schmelz21 added this to Review in progress in Sprint 3 (8/15 - 9/15) Sep 3, 2021
@schmelz21 schmelz21 moved this from Review in progress to Done in Sprint 3 (8/15 - 9/15) Sep 3, 2021
@schmelz21 schmelz21 linked an issue Sep 8, 2021 that may be closed by this pull request
1 task
aloftus23 pushed a commit that referenced this pull request Apr 13, 2022
Add credential exposure tables and adjust foreign keys
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation This issue or pull request improves or adds to documentation
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Primary Key integer or UUID Credential Exposure Data Schema
5 participants