Skip to content
This repository has been archived by the owner on Feb 14, 2024. It is now read-only.

add organization to the data schema for hibp #58

Merged
merged 1 commit into from
Sep 14, 2021

Conversation

DJensen94
Copy link
Contributor

@DJensen94 DJensen94 commented Sep 13, 2021

Added the organization to the data schema to facilitate querying for report generation

🗣 Description

This PR only adds one field to the hibp_exposed_credentials table and the hibp view

💭 Motivation and context

Previously there was no way to easily query all credential breaches for a specific organization. adding this field to the table and view will allow us to pull all values for a specific organization in a specified time frame.

🧪 Testing

Should pass with the same tests as before

✅ Checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.

Added the organization to the data schema to facilitate querying for report generation
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1231173790

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 76.987%

Totals Coverage Status
Change from base Build 1217891029: 0.0%
Covered Lines: 174
Relevant Lines: 217

💛 - Coveralls

@schmelz21 schmelz21 added the improvement This issue or pull request will add or improve functionality, maintainability, or ease of use label Sep 14, 2021
@DJensen94 DJensen94 marked this pull request as ready for review September 14, 2021 13:25
Copy link
Collaborator

@schmelz21 schmelz21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor adjustment looks good.

@schmelz21 schmelz21 merged commit 67f54d8 into develop Sep 14, 2021
@schmelz21 schmelz21 deleted the dj-working-updateSql branch September 14, 2021 13:37
aloftus23 pushed a commit that referenced this pull request Apr 13, 2022
add organization to the data schema for hibp
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
improvement This issue or pull request will add or improve functionality, maintainability, or ease of use
Projects
No open projects
Sprint 3 (8/15 - 9/15)
Awaiting triage
Development

Successfully merging this pull request may close these issues.

None yet

4 participants