-
Notifications
You must be signed in to change notification settings - Fork 5
Conversation
This update will change the id columns data type to uuid of all tables and enables uuid in Postgres.
Pull Request Test Coverage Report for Build 1237867968
💛 - Coveralls |
Get all new changes from develop repo..
@cduhn17 I like this idea, just a couple of quick thoughts to run by you:
|
@schmelz-ctr , I agree with creating a single identified "id" column. I like the simplicity and ease to write "_uid" that way when reading/writing and execution sql statements i.e. joins. As well as the reasons that you mentioned. |
Makes sense.. for now agree simpler the better. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Sort the Package Requirements in setup.py
Replace id column data type
Sort the Package Requirements in setup.py
This update will change the id columns data type to uuid of all tables and enables uuid in Postgres.
🗣 Description
The "id" column data type ''text" is replaced with uuid at all table schema.
💭 Motivation and context
The motivation is to future proof the table schema in the event the database is merged into a data warehouse where there may be many of the same schema getting merged together. When operations like this happen the id columns of each database to be merged , would have duplicate id integers. The id column is primary key and as a result duplicated "id" would be filtered out of the data to be merged and the data would be lost. This PR addresses issue #49
🧪 Testing
✅ Checklist
in code comments.
to reflect the changes in this PR.