Skip to content
This repository has been archived by the owner on Feb 14, 2024. It is now read-only.

Remove htmx functionality #596

Merged
merged 4 commits into from
Jul 10, 2023
Merged

Remove htmx functionality #596

merged 4 commits into from
Jul 10, 2023

Conversation

aloftus23
Copy link
Contributor

@aloftus23 aloftus23 commented Jun 30, 2023 •
edited

🗣 Description

HTMX is no longer needed.

💭 Motivation and context

No longer in use and presents potential vulnerabilities.

-->

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced
    in code comments.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

@coveralls
Copy link

coveralls commented Jun 30, 2023 •
edited

Coverage Status

coverage: 26.288%. remained the same when pulling 2ba1731 on AL-fix-htmlx-vuln into 1475518 on develop.

@aloftus23 aloftus23 self-assigned this Jul 5, 2023
@aloftus23
Copy link
Contributor Author

aloftus23 commented Jul 5, 2023 •
edited

@dav3r @jsf9k This is ready for review.

cduhn17
cduhn17 approved these changes Jul 10, 2023
View reviewed changes
Copy link
Collaborator

@cduhn17 cduhn17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cduhn17 cduhn17 merged commit 1ac5df8 into develop Jul 10, 2023
44 checks passed
@cduhn17 cduhn17 deleted the AL-fix-htmlx-vuln branch July 10, 2023 15:00
@dav3r dav3r mentioned this pull request Jul 14, 2023
Merged
12 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jsf9k jsf9k jsf9k approved these changes

@cduhn17 cduhn17 cduhn17 approved these changes

@dav3r dav3r Awaiting requested review from dav3r dav3r is a code owner

@DJensen94 DJensen94 Awaiting requested review from DJensen94 DJensen94 is a code owner

@felddy felddy Awaiting requested review from felddy felddy is a code owner

@jasonodoom jasonodoom Awaiting requested review from jasonodoom jasonodoom is a code owner

@mcdonnnj mcdonnnj Awaiting requested review from mcdonnnj mcdonnnj is a code owner

@stewartl97 stewartl97 Awaiting requested review from stewartl97 stewartl97 is a code owner

Assignees

@aloftus23 aloftus23

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@aloftus23 @coveralls @jsf9k @cduhn17