-
Notifications
You must be signed in to change notification settings - Fork 5
Conversation
Updated the get_intelx_breaches() in db_query_source.py to use API instead of TSQL query
…into EM-get-org-api
@edujosemena You should ensure that you have done all of the items in the "Pre-approval checklist" (and checked the checkboxes) before requesting approval of this PR. You may delete any that don't apply, e.g. if you have no TODO items, you may remove the "All future TODOs are captured in issues, which are referenced in code comments." item. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks OK to me, but please consider my one suggestion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me aside from one minor thing I mentioned.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requesting correction of one documentation oversight.
Fixes #639
🗣 Description
For preventing sql injection errors the team is focusing on creating more API endpoints to interact with instead of using direct API calls. To get this going we need to modify the get_orgs function in db_query to get the data from the api endpoint in crossfeed rather than directly use TSQL.
Implementation notes
🧪 Testing
API endpoint is successfully called using the requests library
✅ Pre-approval checklist