Skip to content
This repository has been archived by the owner on Feb 14, 2024. It is now read-only.

Add P&E Mailer tests for pe-mailer #69

Merged
merged 13 commits into from
Oct 12, 2021
Merged

Add P&E Mailer tests for pe-mailer #69

merged 13 commits into from
Oct 12, 2021

Conversation

schmelz21
Copy link
Collaborator

@schmelz21 schmelz21 commented Sep 23, 2021 •
edited

The P&E Reports module pe-mailer needs "tests" for better quality control.

🗣 Description

Where applicable, add pe-mailer test to/tests. Code referenced from the following standards :

💭 Motivation and context

Meets expectations of the cisagov code standards.

🧪 Testing

  • All test PASS on run: pytest tests/

✅ Checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced
    in code comments.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

@schmelz21 schmelz21 added improvement This issue or pull request will add or improve functionality, maintainability, or ease of use upstream update This issue or pull request pulls in upstream updates labels Sep 23, 2021
@schmelz21 schmelz21 self-assigned this Sep 23, 2021
@coveralls
Copy link

coveralls commented Sep 23, 2021 •
edited

Pull Request Test Coverage Report for Build 1321688305

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 76.987%
Totals Coverage Status
Change from base Build 1321008625: 0.0%
Covered Lines: 174
Relevant Lines: 217
💛 - Coveralls

@schmelz21 schmelz21 added this to Pull Request in Sprint 4 (9/15 – 10/1) Sep 23, 2021
@schmelz21 schmelz21 added the blocked This issue or pull request is awaiting the outcome of another issue or pull request label Sep 23, 2021
This was linked to issues Sep 23, 2021
Add P&E Mailer Automation - Module #17
Closed
pe-mailer module "tests" #56
Closed
@schmelz21 schmelz21 marked this pull request as ready for review September 23, 2021 19:52
@schmelz21 schmelz21 added this to Pull Request in Sprint 5 (10/1 - 10/15) Sep 30, 2021
@schmelz21 schmelz21 removed blocked This issue or pull request is awaiting the outcome of another issue or pull request upstream update This issue or pull request pulls in upstream updates labels Oct 8, 2021
@schmelz21
Copy link
Collaborator Author

@cduhn17, @jsf9k, @dav3r
I realized this should of been in draft mode while #48 was pending approval.
I am sure its nice to finally see one of ours not so loaded with changes and limited in scope!

When you have time, please review this PR - Thanks

dav3r
dav3r suggested changes Oct 8, 2021
View reviewed changes
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please take a look at my questions and suggestions.

src/pe_mailer/__init__.py Show resolved Hide resolved
tests/test_pe_mailer.py Outdated Show resolved Hide resolved
tests/test_pe_reports.py Show resolved Hide resolved
tests/data/csv-sample.csv Outdated Show resolved Hide resolved
schmelz21 and others added 4 commits October 8, 2021 15:36
@schmelz21 schmelz21 requested a review from dav3r October 8, 2021 19:54
dav3r
dav3r approved these changes Oct 12, 2021
View reviewed changes
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all LGTM now - thanks! 👍

@schmelz21 schmelz21 merged commit 4eee505 into develop Oct 12, 2021
@schmelz21 schmelz21 deleted the wip-pe-mailer-tests branch October 12, 2021 14:24
@schmelz21 schmelz21 moved this from Pull Request to Done in Sprint 5 (10/1 - 10/15) Oct 12, 2021
aloftus23 pushed a commit that referenced this pull request Apr 13, 2022
@mcdonnnj
Merge pull request #69 from cisagov/bugfix/update_codeql_workflow
a15bf35 
Update CodeQL Workflow for GitHub Actions
aloftus23 pushed a commit that referenced this pull request Apr 13, 2022
@schmelz21
Merge pull request #69 from cisagov/wip-pe-mailer-tests
6a59721 
Add P&E Mailer tests for pe-mailer
aloftus23 pushed a commit that referenced this pull request Apr 15, 2022
@mcdonnnj
Merge pull request #69 from cisagov/bugfix/update_codeql_workflow
927c802 
Update CodeQL Workflow for GitHub Actions
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jsf9k jsf9k jsf9k approved these changes

@dav3r dav3r dav3r approved these changes

@aloftus23 aloftus23 Awaiting requested review from aloftus23 aloftus23 is a code owner

@cduhn17 cduhn17 Awaiting requested review from cduhn17 cduhn17 is a code owner

@DJensen94 DJensen94 Awaiting requested review from DJensen94 DJensen94 is a code owner

@elr64 elr64 Awaiting requested review from elr64

@felddy felddy Awaiting requested review from felddy felddy is a code owner

@mcdonnnj mcdonnnj Awaiting requested review from mcdonnnj mcdonnnj is a code owner

@stewartl97 stewartl97 Awaiting requested review from stewartl97 stewartl97 is a code owner

Assignees

@schmelz21 schmelz21

Labels
improvement This issue or pull request will add or improve functionality, maintainability, or ease of use
Projects
No open projects
Sprint 4 (9/15 – 10/1)
Pull Request
Sprint 5 (10/1 - 10/15)
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pe-mailer module "tests" Add P&E Mailer Automation - Module
4 participants
@schmelz21 @coveralls @jsf9k @dav3r