Skip to content
This repository has been archived by the owner on Feb 14, 2024. It is now read-only.

Update SQL schema #71

Merged
merged 9 commits into from
Nov 8, 2021
Merged

Update SQL schema #71

merged 9 commits into from
Nov 8, 2021

Conversation

DJensen94
Copy link
Contributor

Add additional tables to ensure we can track all assets associated to each organization

🗣 Description

We currently don't have tables to track our asset tracking process, this PR is to add new tables that will hold domain and IP data for each organization

🧪 Testing

Same testing as past SQL creation statement updates

✅ Checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced
    in code comments.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

DJensen94 and others added 2 commits September 30, 2021 15:59
Add additional tables to ensure we can track all assets associated to each organization
@coveralls
Copy link

coveralls commented Sep 30, 2021

Pull Request Test Coverage Report for Build 1436410039

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 76.987%

Totals Coverage Status
Change from base Build 1412845839: 0.0%
Covered Lines: 174
Relevant Lines: 217

💛 - Coveralls

@schmelz21 schmelz21 added this to Pull Request in Sprint 5 (10/1 - 10/15) Oct 4, 2021
removed duplicate column and fixed relationship in the view
@schmelz21 schmelz21 added the improvement This issue or pull request will add or improve functionality, maintainability, or ease of use label Oct 15, 2021
@schmelz21 schmelz21 changed the title Add root_domain, subdomain and IP tables Update SQL schema Nov 1, 2021
@schmelz21
Copy link
Collaborator

@DJensen94 and @cduhn17 might be worth getting this up to date and pushed as we head toward implying metrics and charts. Ideally, to run tests locally on a set of 'dummy' data.
What do you think...?

reworked various tables to better fit our criteria
Adjust link table name to match earlier updated naming
@cduhn17
Copy link
Collaborator

cduhn17 commented Nov 8, 2021

@DJensen94 @schmelz21
I think that is a great idea getting this PR merged.

added new field to track where the asset originated from
@DJensen94 DJensen94 marked this pull request as ready for review November 8, 2021 19:40
Copy link
Contributor

@aloftus23 aloftus23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good

Copy link
Collaborator

@cduhn17 cduhn17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good.

@cduhn17 cduhn17 merged commit ea53166 into develop Nov 8, 2021
@cduhn17 cduhn17 deleted the DJ-SQLupdate-update branch November 8, 2021 20:05
aloftus23 pushed a commit that referenced this pull request Apr 13, 2022
…configuration

Update coveralls-python Configuration in GitHub Actions Workflow
aloftus23 pushed a commit that referenced this pull request Apr 13, 2022
aloftus23 pushed a commit that referenced this pull request Apr 15, 2022
…configuration

Update coveralls-python Configuration in GitHub Actions Workflow
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
improvement This issue or pull request will add or improve functionality, maintainability, or ease of use
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

5 participants