This repository has been archived by the owner on Feb 14, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add additional tables to ensure we can track all assets associated to each organization
Pull Request Test Coverage Report for Build 1436410039
💛 - Coveralls |
add ip type to the ip table
…eports into DJ-SQLupdate-update
removed duplicate column and fixed relationship in the view
schmelz21
added
the
improvement
This issue or pull request will add or improve functionality, maintainability, or ease of use
label
Oct 15, 2021
@DJensen94 and @cduhn17 might be worth getting this up to date and pushed as we head toward implying metrics and charts. Ideally, to run tests locally on a set of 'dummy' data. |
reworked various tables to better fit our criteria
Adjust link table name to match earlier updated naming
@DJensen94 @schmelz21 |
added new field to track where the asset originated from
DJensen94
requested review from
aloftus23,
cduhn17,
dav3r,
felddy,
jsf9k,
mcdonnnj and
stewartl97
as code owners
November 8, 2021 19:40
aloftus23
approved these changes
Nov 8, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look good
cduhn17
approved these changes
Nov 8, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look good.
aloftus23
pushed a commit
that referenced
this pull request
Apr 13, 2022
…configuration Update coveralls-python Configuration in GitHub Actions Workflow
aloftus23
pushed a commit
that referenced
this pull request
Apr 15, 2022
…configuration Update coveralls-python Configuration in GitHub Actions Workflow
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
improvement
This issue or pull request will add or improve functionality, maintainability, or ease of use
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add additional tables to ensure we can track all assets associated to each organization
🗣 Description
We currently don't have tables to track our asset tracking process, this PR is to add new tables that will hold domain and IP data for each organization
🧪 Testing
Same testing as past SQL creation statement updates
✅ Checklist
in code comments.
to reflect the changes in this PR.