This repository has been archived by the owner on Feb 14, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 5
Update Command Line 'Usage' for pe-reports #72
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schmelz21
added
improvement
This issue or pull request will add or improve functionality, maintainability, or ease of use
upstream update
This issue or pull request pulls in upstream updates
version bump
This issue or pull request increments the version number
labels
Oct 1, 2021
Pull Request Test Coverage Report for Build 1296005731
💛 - Coveralls |
@cisagov/posture-and-exposure
Default - if no "Date" or "Customer" is listed in cmd-line args, the reports produced are from the last available reporting period and generated for all the customers. |
schmelz21
added
invalid
This issue or pull request is not applicable, incorrect, or obsolete
wontfix
This issue will not be incorporated
and removed
upstream update
This issue or pull request pulls in upstream updates
version bump
This issue or pull request increments the version number
labels
Nov 8, 2021
Currently out of scope for next 2 sprints. A new solution may be occur due to change in priorities and code architecture. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
improvement
This issue or pull request will add or improve functionality, maintainability, or ease of use
invalid
This issue or pull request is not applicable, incorrect, or obsolete
wontfix
This issue will not be incorporated
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
Proposed in issue - #54 (comment) to simplify command-line inputs and build continuity to both the pe-reports and pe-mailer module usage.
💭 Motivation and context
Implementation of the following 'Usage' would be applied. Updates are made specifically to pe-reports module.
Reports
Mailer
So essentially to run these in sync the following cmd-lines could go:
🧪 Testing
The following processes must run successfully
Install:
pip install -e .
Tests:
pytest /tests
Additionally pass all pre-commits
pre-commit run --all-files
📷 Screenshots (if appropriate)
✅ Checklist
in code comments.
to reflect the changes in this PR.