This repository has been archived by the owner on Feb 14, 2024. It is now read-only.
Add database connection config #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This hook should now work as expected in most, if not all of our repos now that we are finally updating to terraform 0.13.x (on our way to 1.0.x).
…f_0.13 This change will be reverted when testing is completed.
Initialization will now be done during the "terraform validate" step.
…upport_tf_0.13" This reverts commit 6a7fbf0.
…date Enable terraform validate pre-commit hook
Add Python 3.10 to the matrices of versions used by the `test` and `build` steps.
Ensure that the versions listed in the version matrices used by the `test` and `build` jobs are interpreted as strings. Without this change the version `3.10` is interpreted as `3.1` when converted to a fixnum. Since these are intended to be interpreted as string values we should enforce it for all versions listed.
Update pre-commit hooks using `pre-commit autoupdate`. The `ansible-lint` hook is intentionally held back due to issues with switching to v5.
Update `pre-commit` Hooks
This file is copied from cisagov/skeleton-ansible-role#85 and tweaked to pass pre-commit. See here for for a list of the elements that can exist in this file: https://ansible-lint.readthedocs.io/en/latest/configuring.html Co-authored-by: Shane Frasier <jeremy.frasier@trio.dhs.gov>
…re-commit_version Update the `ansible-lint` Version in the pre-commit Configuration
This will configure `dependabot` to scan Terraform configurations if they exist in a repository. If a repository stores a Terraform configuration in a sub- directory this configuration will need to be modified or an additional configuration must be added if there still exists a Terraform configuration in the root directory.
…uration_for_terraform Add `dependabot` Configuration for Terraform
Change from using an environment variable to the outputs of the cisagov/setup-env-github-action instead.
We use a `PACKER_VERSION` environment variable for the "Install Packer" step that is populated from the `setup-env` outputs to get around `yamllint` lint length limits.
We change the "Install shfmt" step to use two local environment variables to provide the package's URL and version to install. This allows us to work around `yamllint` line length limits.
We change the "Install Terraform-docs" step to use two local environment variables to provide the package's URL and version to install. This allows us to work around `yamllint` line length limits.
This changes from using an environment variable to using a step output to store the Go version that is installed. This mirrors changes made to the other program versions and how they're stored.
Use Outputs of cisagov/setup-env-github-action to Control Installed Program Versions
cduhn17
added
improvement
Pull Request Test Coverage Report for Build 1412761643
💛 - Coveralls |
dav3r
suggested changes
Oct 29, 2021
Lineage pull request for: skeleton
Add Support for Python 3.10
Override the default by setting `fail-fast` to `false` for the test and build jobs in our GHA build workflow. This ensure that all matrix jobs run regardless of a failure.
…_test_and_build_jobs Disable `fail-fast` for GitHub Actions Jobs with a Matrix Strategy
Lineage pull request for: skeleton
Co-authored-by: schmelz21 <81192860+schmelz21@users.noreply.github.com>
Co-authored-by: dav3r <david.redmin@trio.dhs.gov>
Co-authored-by: dav3r <david.redmin@trio.dhs.gov>
|
@schmelz21 |
|
@cduhn17 - Just about good to go here; I will re-review after you respond to #91 (comment). |
Co-authored-by: schmelz21 <81192860+schmelz21@users.noreply.github.com>
6 tasks
cisagovbot
pushed a commit
that referenced
this pull request
Mar 7, 2022
Lineage pull request for: skeleton
aloftus23
pushed a commit
that referenced
this pull request
Apr 13, 2022
Add database connection config
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
Create a method to securely make a connection to pe-reports postgres database to use in downstream functions/classes. Resolves #76
💭 Motivation and context
This script sets up the foundation in making a centralized single point for connections to the pe-reports database . This configuration also makes a reference to the raw credentials in place of having the raw credentials in the script.
🧪 Testing
This current PR needs to pass current
pytest /tests✅ Checklist
in code comments.
to reflect the changes in this PR.