Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shift URL for transport_security_state_static.json for new location #240

Closed
mbachtell-nais opened this issue May 8, 2023 · 2 comments
Closed
Assignees
Labels
bug This issue or pull request addresses broken functionality

Comments

@mbachtell-nais
Copy link

mbachtell-nais commented May 8, 2023

馃悰 Summary

The URL for transport_security_state_static.json is currently https://chromium.googlesource.com/chromium/src/net/+/master/http/transport_security_state_static.json?format=TEXT but should be https://chromium.googlesource.com/chromium/src/+/main/net/http/transport_security_state_static.json?format=TEXT.

Expected behavior

The HSTS would preload and pshtt would work (assuming that you are using PR #228 for current versions of Python).

Error
image

Working after URL correction
image

@jsf9k
Copy link
Member

jsf9k commented May 8, 2023

I believe this was fixed in #232. Or am I missing something?

@jsf9k jsf9k self-assigned this May 8, 2023
@jsf9k jsf9k added the bug This issue or pull request addresses broken functionality label May 8, 2023
@mbachtell-nais
Copy link
Author

mbachtell-nais commented May 8, 2023

Ah, you are correct. I'm working off of PR #214 which has the old URL.

I will close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue or pull request addresses broken functionality
Projects
None yet
Development

No branches or pull requests

2 participants