Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken preload URL #232

Merged
merged 5 commits into from Dec 5, 2022
Merged

Fix broken preload URL #232

merged 5 commits into from Dec 5, 2022

Conversation

jsf9k
Copy link
Member

@jsf9k jsf9k commented Dec 4, 2022 •
edited

🗣 Description

This pull request fixes a broken URL pointing to the Chromium HSTS preloaded domain list.

💭 Motivation and context

The location of this data has changed upstream, and this is breaking the BOD 18-01 scanning.

Required to resolve cisagov/scanner#67.

🧪 Testing

All automated testing that is expected to pass passes. The Python 3.6 tests fail because Python 3.6 is no longer supported by GitHub Actions.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.

✅ Pre-merge checklist

  • Finalize version.

✅ Post-merge checklist

@jsf9k jsf9k added bug This issue or pull request addresses broken functionality python Pull requests that update Python code labels Dec 4, 2022
@jsf9k jsf9k self-assigned this Dec 4, 2022
@jsf9k jsf9k added this to In progress in BOD 18-01 via automation Dec 4, 2022
@jsf9k
Copy link
Member Author

jsf9k commented Dec 4, 2022 •
edited

Can we just drop support for Python 3.6? The 3.6 tests are failing because GitHub Actions no longer supports 3.6.

I can just ignore them for now.

@jsf9k jsf9k marked this pull request as ready for review December 4, 2022 18:16
mcdonnnj
mcdonnnj approved these changes Dec 5, 2022
View reviewed changes
Copy link
Member

@mcdonnnj mcdonnnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will drop Python 3.6 support when we update to a newer version of sslyze so I'd rather just leave that alone for now. Do you want to handle the release to PyPI or shall I?

src/pshtt/pshtt.py Outdated Show resolved Hide resolved
dav3r
dav3r approved these changes Dec 5, 2022
View reviewed changes
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

BOD 18-01 automation moved this from In progress to Reviewer approved Dec 5, 2022
jsf9k and others added 2 commits December 5, 2022 10:28
@jsf9k
Bump version from 0.6.9-rc.1 to 0.6.9
2392eb6
@jsf9k @mcdonnnj
Update to equivalent but saner URL
7f40345 
Co-authored-by: Nick <50747025+mcdonnnj@users.noreply.github.com>
@jsf9k jsf9k merged commit 2726e42 into develop Dec 5, 2022
BOD 18-01 automation moved this from Reviewer approved to Done Dec 5, 2022
@jsf9k jsf9k deleted the bugfix/fix-broken-preload-url branch December 5, 2022 15:54
@KeithBonesJr KeithBonesJr mentioned this pull request Dec 20, 2022
Closed
@jsf9k jsf9k mentioned this pull request May 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcdonnnj mcdonnnj mcdonnnj approved these changes

@dav3r dav3r dav3r approved these changes

@felddy felddy Awaiting requested review from felddy felddy is a code owner

Assignees

@jsf9k jsf9k

Labels
bug This issue or pull request addresses broken functionality python Pull requests that update Python code
Projects
BOD 18-01
Status: Done
CyHy System
Status: Done
BOD 18-01
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pshtt scans failed this weekend
3 participants
@jsf9k @dav3r @mcdonnnj