[WIP] Logic changes to bring closer to Pulse scan #3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an in-progress PR documenting some logic changes we're making to bring the
Valid HTTPS
field closer to Pulse's, along with other small things I notice.So far this PR:
requests
library, turned on by--cache
and stored inside.cache/
, which automatically caches (and reuses from cache) all network requests made throughrequests
while it is enabled. This makes therequests
calls go instantly once cached, though thesslyze
calls are not cached.HSTS Preloaded
, so as to catch any manual additions the preload list adds. (For a time,login.gov
was one of these.)include_subdomains
set totrue
, since that's a drastically different security level than we're generally indicating when we sayHSTS Preloaded
. There are a few.gov
domains in this unfortunate position, includinghealthcare.gov
. This is actually ahead of Pulse -- I want Pulse to start discounting those too.