Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Logic changes to bring closer to Pulse scan #3

Merged
merged 6 commits into from
Aug 8, 2016

Conversation

konklone
Copy link
Collaborator

@konklone konklone commented Aug 7, 2016

This is an in-progress PR documenting some logic changes we're making to bring the Valid HTTPS field closer to Pulse's, along with other small things I notice.

So far this PR:

  • Adds a transparent cache for the requests library, turned on by --cache and stored inside .cache/, which automatically caches (and reuses from cache) all network requests made through requests while it is enabled. This makes the requests calls go instantly once cached, though the sslyze calls are not cached.
  • Always checks the preload list for the value of HSTS Preloaded, so as to catch any manual additions the preload list adds. (For a time, login.gov was one of these.)
  • Discount entries in the preload list which don't have include_subdomains set to true, since that's a drastically different security level than we're generally indicating when we say HSTS Preloaded. There are a few .gov domains in this unfortunate position, including healthcare.gov. This is actually ahead of Pulse -- I want Pulse to start discounting those too.

@konklone konklone changed the title Logic changes [WIP] Logic changes to bring closer to Pulse scan Aug 7, 2016
@konklone
Copy link
Collaborator Author

konklone commented Aug 8, 2016

(Note this PR is merging into the previous PR, so if you want to merge both PRs, merge this one first.)

@konklone
Copy link
Collaborator Author

konklone commented Aug 8, 2016

I've added some commits that:

  • Store the location an endpoint immediately redirects to, in addition to the existing one that stores the eventual redirect location.
  • Tightened the is_valid_https definition considerably. It now wants at least one endpoint to be live, not have a certificate for a valid hostname, and to not redirect the user immediately down to HTTP.

@KyleEvers KyleEvers merged commit 4d8b07c into tightening-up Aug 8, 2016
@h-m-f-t h-m-f-t deleted the logic-changes branch August 18, 2016 19:31
mcdonnnj pushed a commit that referenced this pull request Mar 9, 2022
mcdonnnj pushed a commit that referenced this pull request Mar 9, 2022
…generic_changes

Merge latest skeleton-generic changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants