This repository has been archived by the owner on Dec 1, 2022. It is now read-only.
Lineage pull request for: skeleton #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switch from a flow style to a block style sequence in the build workflow. This will improve maintainability by making version changes impact one Python version at a time.
Instead of manually installing a Terraform binary we can leverage the Action provided by Hashicorp to do the same thing.
This sets a specific rule for MD035 (Horizontal rule style) instead of the default value of "consistent".
This sets a specific rule for MD046 (code block style) instead of the default value of "consistent".
Update pre-commit hooks using `pre-commit autoupdate`. The `ansible-lint` hook is intentionally held back due to issues with switching to v5.
Add markdownlint Rules to Enforce Specific Formatting
…n_gha_workflow Use the hashicorp/setup-terraform Action to Install Terraform in GHA Workflow
Lineage pull request for: skeleton
…ock_style_sequence Switch to Block-Style Sequence for Python Versions in build Workflow
cisagovbot
requested review from
dav3r,
felddy,
jsf9k and
mcdonnnj
as code owners
cisagovbot
added
the
upstream update
jsf9k
approved these changes
Aug 26, 2021
dav3r
approved these changes
Aug 26, 2021
This updates the `build_lambda` job's `matrix` property to use a block-style sequence to be consistent with the changes to the `build` and `test` jobs.
Update the `release` workflow to use a block-style sequence in the `matrix` for its `release` job to mirror changes made in the `build` workflow.
jsf9k
suggested changes
Aug 27, 2021
jsf9k
approved these changes
Aug 27, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lineage Pull Request
Lineage has created this pull request to incorporate new changes found in an
upstream repository:
Upstream repository:
https://github.com/cisagov/skeleton-python-library.gitRemote branch:
HEADCheck the changes in this pull request to ensure they won't cause issues with
your project.
Note: You are seeing this because one of this repository's maintainers has
configured Lineage to open pull requests.
For more information:
🛠 Lineage configurations for this project are stored in
.github/lineage.yml📚 Read more about Lineage