This repository has been archived by the owner on Dec 1, 2022. It is now read-only.
Lineage pull request for: skeleton #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This hook should now work as expected in most, if not all of our repos now that we are finally updating to terraform 0.13.x (on our way to 1.0.x).
…f_0.13 This change will be reverted when testing is completed.
Initialization will now be done during the "terraform validate" step.
…upport_tf_0.13" This reverts commit 6a7fbf0.
…date Enable terraform validate pre-commit hook
Add Python 3.10 to the matrices of versions used by the `test` and `build` steps.
Ensure that the versions listed in the version matrices used by the `test` and `build` jobs are interpreted as strings. Without this change the version `3.10` is interpreted as `3.1` when converted to a fixnum. Since these are intended to be interpreted as string values we should enforce it for all versions listed.
Update pre-commit hooks using `pre-commit autoupdate`. The `ansible-lint` hook is intentionally held back due to issues with switching to v5.
Update `pre-commit` Hooks
This file is copied from cisagov/skeleton-ansible-role#85 and tweaked to pass pre-commit. See here for for a list of the elements that can exist in this file: https://ansible-lint.readthedocs.io/en/latest/configuring.html Co-authored-by: Shane Frasier <jeremy.frasier@trio.dhs.gov>
…re-commit_version Update the `ansible-lint` Version in the pre-commit Configuration
This will configure `dependabot` to scan Terraform configurations if they exist in a repository. If a repository stores a Terraform configuration in a sub- directory this configuration will need to be modified or an additional configuration must be added if there still exists a Terraform configuration in the root directory.
…uration_for_terraform Add `dependabot` Configuration for Terraform
Change from using an environment variable to the outputs of the cisagov/setup-env-github-action instead.
We use a `PACKER_VERSION` environment variable for the "Install Packer" step that is populated from the `setup-env` outputs to get around `yamllint` lint length limits.
We change the "Install shfmt" step to use two local environment variables to provide the package's URL and version to install. This allows us to work around `yamllint` line length limits.
We change the "Install Terraform-docs" step to use two local environment variables to provide the package's URL and version to install. This allows us to work around `yamllint` line length limits.
This changes from using an environment variable to using a step output to store the Go version that is installed. This mirrors changes made to the other program versions and how they're stored.
Use Outputs of cisagov/setup-env-github-action to Control Installed Program Versions
Remove the manual exclusion of the `converge.yml` file in the default molecule scenario. With the changes in cisagov/skeleton-ansible-role#88 this exclusion is no longer necessary.
Instead of excluding molecule configurations for systemd individually we instead direct ansible-lint to process any of these configurations in scenario directories as plain yaml files. This mirrors how ansible-lint handles `molecule.yml` files in scenario directories by default.
Lineage pull request for: skeleton
Add Support for Python 3.10
cisagovbot
added
the
upstream update
Override the default by setting `fail-fast` to `false` for the test and build jobs in our GHA build workflow. This ensure that all matrix jobs run regardless of a failure.
…_test_and_build_jobs Disable `fail-fast` for GitHub Actions Jobs with a Matrix Strategy
jsf9k
approved these changes
Oct 29, 2021
dav3r
approved these changes
Nov 1, 2021
Update pre-commit hooks using `pre-commit autoupdate`.
Update `pre-commit` hooks
…onfiguration Update `ansible-lint` Configuration
Lineage pull request for: skeleton
Remove the `types-setuptools` dependency for the mypy hook. This dependency was inherited from the upstream skeleton, but that package is not being used in this project.
dav3r
approved these changes
Jan 13, 2022
jsf9k
approved these changes
Jan 13, 2022
|
@mcdonnnj, should we go ahead and merge this one? Builds are failing without these changes. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lineage Pull Request
Lineage has created this pull request to incorporate new changes found in an
upstream repository:
Upstream repository:
https://github.com/cisagov/skeleton-python-library.gitRemote branch:
HEADCheck the changes in this pull request to ensure they won't cause issues with
your project.
Note: You are seeing this because one of this repository's maintainers has
configured Lineage to open pull requests.
For more information:
🛠 Lineage configurations for this project are stored in
.github/lineage.yml📚 Read more about Lineage