-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add checks for correct semantic version of Python #176
Open
michaelsaki
wants to merge
12
commits into
develop
Choose a base branch
from
improvement/correct-semantic-python-version-checks
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add checks for correct semantic version of Python #176
michaelsaki
wants to merge
12
commits into
develop
from
improvement/correct-semantic-python-version-checks
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit will make a few changes. The orginal version of the semantic checking function was a bit more difficult to read. It is now somewhat easier to follow how the regex is structured. Also the function has been renamed to check_python_version since it has 2 functions, making sure that the version is semantically correct and the second is to make sure that it is installed on the user's machine. This makes it easier to follow the logic for the flags, -p or --python-version and -l or --list-versions
This commit will make a few changes. The orginal version of the semantic checking function was a bit more difficult to read. It is now somewhat easier to follow how the regex is structured. Also the function has been renamed to check_python_version since it has 2 functions, making sure that the version is semantically correct and the second is to make sure that it is installed on the user's machine. This makes it easier to follow the logic for the flags, -p or --python-version and -l or --list-versions
…ttps://github.com/cisagov/skeleton-generic into improvement/correct-semantic-python-version-checks
michaelsaki
added
the
improvement
This issue or pull request will add or improve functionality, maintainability, or ease of use
label
Mar 20, 2024
michaelsaki
requested review from
dav3r,
felddy,
jasonodoom,
jsf9k and
mcdonnnj
as code owners
March 20, 2024 20:10
dav3r
approved these changes
Mar 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to my eyes. 👍
I requested one comment be added and one small grammatical change to another comment.
Co-authored-by: dav3r <david.redmin@trio.dhs.gov>
jsf9k
requested changes
Mar 21, 2024
dav3r
reviewed
Mar 21, 2024
Co-authored-by: dav3r <david.redmin@trio.dhs.gov>
jsf9k
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
improvement
This issue or pull request will add or improve functionality, maintainability, or ease of use
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
Now if a user enters an incorrect semantic version of Python they will get the following message:
"Invalid version of Python: Python follows semantic versioning, so any version string that is not a valid semantic version is an invalid version of Python."
💭 Motivation and context
This PR will address the issue here: #167.
🧪 Testing
I tested this by making a testing script that verified the following examples were valid or invalid semantic versions:
Valid Semantic Versions
Invalid Semantic Versions
✅ Pre-approval checklist
✅ Pre-merge checklist
✅ Post-merge checklist