Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pre-commit Hook Maintenance and Update #63

Merged
merged 8 commits into from
Jan 7, 2021
Merged

pre-commit Hook Maintenance and Update #63

merged 8 commits into from
Jan 7, 2021

Conversation

mcdonnnj
Copy link
Member

🗣 Description

This PR:

  1. Updates the repo URLs for four hooks to be accurate and consistent.
  2. Adds two new hooks from the base pre-commit-hooks.
  3. Has the results of running pre-commit autoupdate.

💭 Motivation and Context

I noticed that the prettier pre-commit hook that we switched to in #55 had been archived. Upon investigating, I saw that the repo handling that had changed, again, but this time to one of the pre-commit mirrors. Since I was already updating that hook, I thought I would audit the other hook URLs while I was making changes.

I also decided to add two new hooks and run an autoupdate to round out a hook maintenance PR.

🧪 Testing

Automated tests pass.

✅ Checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.

@mcdonnnj
Update prettier hook details
b769825 
Per prettier/prettier#8937 the pre-commit hook has
been moved to https://github.com/pre-commit/mirrors-prettier. I have also
updated to the latest version in that repository.
@mcdonnnj
Update black hook repo url
2d6bf50 
At some point the python GitHub organization renamed to psf (Python Software
Foundation). Although it redirects with no issue, I think it should be updated
to reflect the current repository URL.
@mcdonnnj
Remove trailing '.git's from repository URLs
5115bae 
Two hooks had trailing '.git's in the URLs. Although this is not a problem, we
should be consistent in how we format things.
@mcdonnnj
Enable two additional hooks from default pre-commit-hooks
a7f86dd 
Enabled 'check-case-conflict' because of our mixed Linux and macOS development.
Although APFS supports case-sensitive containers, it is not the default as far
as I am aware. Linux filesystems are typically case-sensitive however.

With the merge of cisagov/development-guide#42 we now
have a TOML file in a repository, so it does not hurt to add this hook in case
more are added in the future.
@mcdonnnj
Run pre-commit autoupdate
06159cb
@mcdonnnj mcdonnnj added the improvement This issue or pull request will add or improve functionality, maintainability, or ease of use label Dec 17, 2020
@mcdonnnj mcdonnnj requested a review from dav3r as a code owner December 17, 2020 14:30
@mcdonnnj mcdonnnj self-assigned this Dec 17, 2020
jsf9k
jsf9k approved these changes Dec 17, 2020
View reviewed changes
Copy link
Member

@jsf9k jsf9k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for keeping us updated!

dav3r
dav3r approved these changes Dec 17, 2020
View reviewed changes
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good! 👍

Do we want to put the "blocked" label on this PR to hold it until we are ready for the next Kraken release?

@mcdonnnj mcdonnnj added the blocked This issue or pull request is awaiting the outcome of another issue or pull request label Dec 17, 2020
hillaryj
hillaryj approved these changes Dec 17, 2020
View reviewed changes
Copy link
Contributor

@hillaryj hillaryj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A+!

@mcdonnnj
Update repo URL for the isort hook
d836e91 
I missed that this repository was transfered from the creator, Timothy Crosley,
to the PyCQA organization.
@jsf9k
Copy link
Member

jsf9k commented Dec 17, 2020

Do we want to put the "blocked" label on this PR to hold it until we are ready for the next Kraken release?

"Blocked" implies that another issue or pull request is blocking this one. I suggest creating a new label ("Next Kraken"?) for this purpose.

@mcdonnnj
Copy link
Member Author

Do we want to put the "blocked" label on this PR to hold it until we are ready for the next Kraken release?

"Blocked" implies that another issue or pull request is blocking this one. I suggest creating a new label ("Next Kraken"?) for this purpose.

I would honestly like some kind of "on hold" label to cover waiting for a deployment, a kraken, etc

@jsf9k
Copy link
Member

jsf9k commented Dec 17, 2020

Do we want to put the "blocked" label on this PR to hold it until we are ready for the next Kraken release?

"Blocked" implies that another issue or pull request is blocking this one. I suggest creating a new label ("Next Kraken"?) for this purpose.

I would honestly like some kind of "on hold" label to cover waiting for a deployment, a kraken, etc

I am fine with an "On Hold" label that is distinct from "Blocked". Probably @felddy can add a phone receiver emoji as well.

@jsf9k jsf9k mentioned this pull request Dec 18, 2020
Open
@mcdonnnj mcdonnnj added this to In progress in Skeleton Maintenance via automation Dec 31, 2020
@mcdonnnj
Copy link
Member Author

@jsf9k Alerted me that the URL for the ansible-lint hook has changed, so I have updated it in keeping with the other changes in this PR. I also ran pre-commit autoupdate again, and will run it on Thursday of next week before the planned merge of this PR.

@mcdonnnj mcdonnnj merged commit 01e3f84 into develop Jan 7, 2021
Skeleton Maintenance automation moved this from In progress to Done Jan 7, 2021
@mcdonnnj mcdonnnj deleted the pre-commit_hook_maintenance branch January 7, 2021 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsf9k jsf9k jsf9k approved these changes

@hillaryj hillaryj hillaryj approved these changes

@dav3r dav3r dav3r approved these changes

@felddy felddy Awaiting requested review from felddy felddy is a code owner

Assignees

@mcdonnnj mcdonnnj

Labels
blocked This issue or pull request is awaiting the outcome of another issue or pull request improvement This issue or pull request will add or improve functionality, maintainability, or ease of use
Projects
Skeleton Maintenance
Status: Done
Skeleton Maintenance
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mcdonnnj @jsf9k @hillaryj @dav3r