Skip to content

Commit

Permalink
Set fail-fast to false for GHA jobs
Browse files Browse the repository at this point in the history
In the `test` and `build` jobs of the `build` workflow we leverage the strategy
matrix feature to parallelize runs on different Python versions. However, the
default value of `true` for the `fail-fast` option means that if one of the
runs fails then all others will be canceled. This changes that behavior so all
runs will be allowed to finish even if some runs fail.
  • Loading branch information
mcdonnnj committed Aug 2, 2021
1 parent 30b1756 commit 7559c31
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,7 @@ jobs:
test:
runs-on: ubuntu-latest
strategy:
fail-fast: false
matrix:
python-version: [3.6, 3.7, 3.8, 3.9]
steps:
Expand Down Expand Up @@ -198,6 +199,7 @@ jobs:
runs-on: ubuntu-latest
needs: [lint, test]
strategy:
fail-fast: false
matrix:
python-version: [3.6, 3.7, 3.8, 3.9]
steps:
Expand Down

0 comments on commit 7559c31

Please sign in to comment.