Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvement/upstream #43

Merged
merged 12 commits into from
May 21, 2020
Merged

Improvement/upstream #43

merged 12 commits into from
May 21, 2020

Conversation

felddy
Copy link
Member

@felddy felddy commented May 21, 2020

🗣 Description

Upstream jazz hadn't made it here.

💭 Motivation and Context

Need upstream jazz.

🧪 Testing

All tests passing.

📷 Screenshots (if appropriate)

🚥 Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (causes existing functionality to change)

✅ Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

felddy and others added 12 commits April 30, 2020 23:31
@felddy
Allow events from apb to rebuild this repository weekly.
8c99c52
@felddy
Merge pull request #43 from cisagov/improvement/apb-events
3301dfa 
Allow events from apb to rebuild this repository weekly.
@mcdonnnj
Updated pre-commit configuration with 'pre-commit autoupdate'.
7d7a677
@mcdonnnj
Update isort pre-commit hook source repository.
ce6658a 
The mirrors-isort respository has been deprecated per this Pull Request:
pre-commit/mirrors-isort#13
Since isort includes pre-commit configuration in current versions we will
switch to using it directly.
@mcdonnnj
Ran pre-commit autoupdate.
daaebc1
@mcdonnnj
Remove legacy comment from the isort hook declaration.
2399f24 
This comment references the mirrors-isort repository that we are no longer
using.
@mcdonnnj
Disable the terraform_validate hook.
fe4d5eb 
We have seen a number of issues related to this hook ever since it was
re-enabled. It will need to remain disabled until at least the 0.13 Terraform
release, and can only be re-enabled if all issues we have seen have been
resolved in how `terraform validate` operates.
@mcdonnnj
Merge branch 'develop' into improvements/pre-commit_autoupdate_2020-05
4d4db07
@mcdonnnj
Add final statement to descriptionf or why terraform_validate is disa…
f831ef8 
…bled.

Review noticed that there lacked a determination for what we were doing about
the problem with the terraform_validate hook. I described the problems but
failed to mention what our path forward would be. This commit rectifies that
oversight.
@mcdonnnj
Merge branch 'improvements/pre-commit_autoupdate_2020-05' of github.c…
64edcc2 
…om:cisagov/skeleton-generic into improvements/pre-commit_autoupdate_2020-05
@mcdonnnj
Merge pull request #44 from cisagov/improvements/pre-commit_autoupdat…
70f0cbd 
…e_2020-05

Update pre-commit Hook Versions
@felddy
Merge github.com:cisagov/skeleton-generic into improvement/upstream
5dded15
@felddy felddy requested review from dav3r, hillaryj, jsf9k, mcdonnnj and a team as code owners May 21, 2020 15:25
@felddy felddy self-assigned this May 21, 2020
@felddy felddy added this to In progress in Skeleton Maintenance via automation May 21, 2020
@felddy felddy mentioned this pull request May 21, 2020
Merged
1 task
dav3r
dav3r approved these changes May 21, 2020
View reviewed changes
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍

Skeleton Maintenance automation moved this from In progress to Reviewer approved May 21, 2020
jsf9k
jsf9k approved these changes May 21, 2020
View reviewed changes
Copy link
Member

@jsf9k jsf9k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All that jazz!

@felddy felddy merged commit 2e48716 into develop May 21, 2020
Skeleton Maintenance automation moved this from Reviewer approved to Done May 21, 2020
@felddy felddy deleted the improvement/upstream branch May 21, 2020 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsf9k jsf9k jsf9k approved these changes

@dav3r dav3r dav3r approved these changes

@hillaryj hillaryj Awaiting requested review from hillaryj

@mcdonnnj mcdonnnj Awaiting requested review from mcdonnnj mcdonnnj is a code owner

Assignees

@felddy felddy

Labels
None yet
Projects
Skeleton Maintenance
Status: Done
Skeleton Maintenance
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@felddy @jsf9k @dav3r @mcdonnnj