Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvement pytest #7

Merged
merged 26 commits into from
May 6, 2019
Merged

Improvement pytest #7

merged 26 commits into from
May 6, 2019

Conversation

felddy
Copy link
Member

@felddy felddy commented May 5, 2019

No description provided.

felddy added 25 commits May 5, 2019 00:00
@felddy
Add pytest examples and configure travis to call
e13fb00
@felddy
Ignore coverage output
edf020a
@felddy
Add coverage check to travis config
124379f
@felddy
Add coveralls
69ba1e2
@felddy
Add coverage shield
828e4ee
@felddy
Add missing term to coverage report
8a27b48
@felddy
Merge branch 'improvement-bandit-config' of github.com:cisagov/skelet…
d1d3569 
…on-generic into improvement-pytest
@felddy
Add configurations for pytest and pytest-cov
8050005
@felddy
Standardize version information source
9dfed07
@felddy
Add a success return code
92576a7
@felddy
Add more tests and disable bandit assert use check
42899a3
@felddy
Rename foolish log level
5965f0e
@felddy
Back out changes to setup.py version fetch... chicken and egg.
7c4e565
@felddy
Add ignore for pytest cache directory
62bbd80
@felddy
Convert to a src layout.
797a699 
See: https://blog.ionelmc.ro/2014/05/25/python-packaging/#the-structure
@felddy
Add option to pytest to show extra test summary info
96591da
@felddy
Add sample conftest file.
7394753
@felddy
Clarify comment.
da671bb
@felddy
Make pytest source declaration more explicit and less magical
8e4e79d
@felddy
Remove bandit nosec comment since we now configure bandit
a748e45
@felddy
Add a slow test for demonstration.
96076b4
@felddy
Add section about pytest to contribution document.
eb2a0a5
@felddy
Merge commit '76999e2466858ce2610ef53058870584de7f936b' of github.com…
c0be22f 
…:cisagov/skeleton-generic into improvement-pytest
@felddy
Improve version handling
4f8b3fa
@felddy
Merge branch 'develop' into improvement-pytest
bdbac43
@felddy felddy marked this pull request as ready for review May 6, 2019 17:02
@felddy felddy requested a review from a team May 6, 2019 17:03
@felddy felddy self-assigned this May 6, 2019
@felddy
Copy link
Member Author

felddy commented May 6, 2019

So this PR adds unit tests, and code coverage checks. I think we should start maturing our test writing chops sooner than later. As the team grows the tests will give new members some confidence that they aren't committing system breaking changes. Also, chasing a 100% code-coverage can be a new pastime.

A bigger change is that I moved example into a src directory.
I was convinced of this for a few reasons, one of which was this blog post:
https://blog.ionelmc.ro/2014/05/25/python-packaging/#the-structure

Let me know what you think.

jsf9k
jsf9k requested changes May 6, 2019
View reviewed changes
Copy link
Member

@jsf9k jsf9k left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these changes are good, but please see my comment. Ideally we could find a solution that lets us run bandit with the assert check enabled on the library code and disabled on the unit test code.

I wholeheartedly agree that we need to get into the test writing business. 👍

.bandit.yml Show resolved Hide resolved
@felddy
Split bandit pre-commit checks into two diffrent runs
c934af3 
One for tests and one for everthing else.
@felddy felddy requested a review from jsf9k May 6, 2019 18:38
jsf9k
jsf9k approved these changes May 6, 2019
View reviewed changes
Copy link
Member

@jsf9k jsf9k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great solution!

@felddy
Copy link
Member Author

felddy commented May 6, 2019

Check out this new thang:
image

@jsf9k
Copy link
Member

jsf9k commented May 6, 2019

Check out this new thang:
image

Yes, I saw that thang!

@felddy felddy merged commit 74d9406 into develop May 6, 2019
@felddy felddy deleted the improvement-pytest branch May 6, 2019 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsf9k jsf9k jsf9k approved these changes

Assignees

@felddy felddy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@felddy @jsf9k