Update coveralls-python Configuration in GitHub Actions Workflow #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coveralls-python has better integration with running in GitHub Actions now, so we can use the automatically generated GITHUB_TOKEN secret instead of manually setting a COVERALLS_REPO_TOKEN secret for each repository.
mcdonnnj
added
bug
dav3r
approved these changes
Apr 5, 2021
.github/workflows/build.yml
Outdated
Comment on lines
78
to
79
| COVERALLS_SERVICE_NAME: github | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| COVERALLS_FLAG_NAME: "py${{ matrix.python-version }}" | ||
| COVERALLS_PARALLEL: true |
There was a problem hiding this comment.
Sort environment variables alphabetically:
Suggested change
| COVERALLS_SERVICE_NAME: github | |
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | |
| COVERALLS_FLAG_NAME: "py${{ matrix.python-version }}" | |
| COVERALLS_PARALLEL: true | |
| COVERALLS_FLAG_NAME: "py${{ matrix.python-version }}" | |
| COVERALLS_PARALLEL: true | |
| COVERALLS_SERVICE_NAME: github | |
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} |
mcdonnnj
force-pushed
the
improvement/update_gha_coveralls_configuration
branch
from
7f57cc0
to
30a1c14
Compare
We already ran our tests in parallel for each major version of Python a project supports. This change should better differentiate each test job run in the reports submitted.
jsf9k
approved these changes
Apr 5, 2021
mcdonnnj
added
the
blocked
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
This PR updates the configuration for
coveralls-pythonin our GitHub Actions workflow to use the automatically createdGITHUB_TOKENsecret instead of a per-repoCOVERALLS_REPO_TOKENwe have used previously to close #70. It also tags each individualtestjob (one per Python version supported) at https://coveralls.io by changing our configuration to reflect that the job runs in parallel.💭 Motivation and context
@dav3r ran into an issue with how
coveralls-pythonis run in our GitHub Actions workflow in cisagov/gophish-tools#29. He determined the fix was the update the configuration to what was described in the documentation. I believe we have run afoul of changes incoveralls-pythonv3 to the order in which configurations are processed.🧪 Testing
Automated tests run without issue, and I confirmed both that coverage reports were uploaded and that the tagging for parallel tasks is working.
✅ Checklist