-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update payloads_not_blocked to host_not_blocked in report_generator.py #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ameliav
requested review from
JCantu248,
nickviola and
schmelz21
as code owners
November 2, 2023 15:43
Pull Request Test Coverage Report for Build 6734918259
π - Coveralls |
schmelz21
approved these changes
Nov 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved.
@JCantu248 or @nickviola are you able to take a quick look?
FYI - as of now current report backlog = 8 |
nickviola
approved these changes
Nov 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
dav3r
reviewed
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π£ Description
Update payloads_not_blocked to host_not_blocked in report_generator.py
π Motivation and context
"We expected the total payloads executed value to match the total number of Not Blocked's in the Host Protection Column of the payloads." Found in issue #65
π§ͺ Testing
I created the report a few times with different input values to determine that the result matched.
π· Screenshots
The screenshot show that it is only capturing the total amount from host protection.
β Pre-approval checklist
in code comments.
to reflect the changes in this PR.
β Pre-merge checklist
β Post-merge checklist