Gracefully handle MX records that do not resolve to an A record #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that we are giving credit for STARTTLS for such a case, since we cannot evaluate it.
Those versions don't support f-strings.
jsf9k
added a commit
to cisagov/lambda_functions
that referenced
this pull request
May 16, 2019
The latest version of trustymail more gracefully handles mail servers that only support IPv6. See here for details: cisagov/trustymail#117
jsf9k
added a commit
to 18F/domain-scan
that referenced
this pull request
May 16, 2019
The latest version of trustymail more gracefully handles mail servers that only support IPv6. See cisagov/trustymail#117 for more details.
mcdonnnj
added a commit
that referenced
this pull request
Jan 23, 2023
…-length_rules Update the `line-length` configuration for `yamllint`
mcdonnnj
added a commit
that referenced
this pull request
Jan 23, 2023
…ttributions Add ignore directives to the dependabot configuration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases (
epa.govis one) a domain may have some MX records that do not resolve to any A record. The corresponding mail server is IPv6-only. Unfortunately our scanning apparatus is IPv4-only. This case was resulting in an unhandled exception being thrown.With this change we now gracefully handle an MX record that does not resolve to an IPv4 address.
Note that we are giving credit for STARTTLS for the mail server, since we cannot evaluate it.