Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up the README post-skeletonization #127

Merged
merged 5 commits into from Jan 23, 2023
Merged

Conversation

mcdonnnj
Copy link
Member

🗣 Description

This pull request fixes some things I missed in #125 as well as some minor cleanup.

💭 Motivation and context

The installation/running directions were not updated appropriately with the changes in #125. Since I already needed to fix that portion of the README I did a quick skim of the rest while I was working on the branch.

🧪 Testing

Automated tests pass. I confirmed the README renders as expected when viewing the branch.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.

Since the `scripts/trustymail` file is now integrated directly into the
Python package the installation and usage directions in the README must
be updated.
Copy in the current configuration of options from the `trustymail.cli`
module.
Make sure all titles are using sentence case as appropriate. Update
titles that use acronyms to include the acronym's meaning.
@mcdonnnj mcdonnnj added documentation This issue or pull request improves or adds to documentation improvement This issue or pull request will add or improve functionality, maintainability, or ease of use labels Jan 23, 2023
@mcdonnnj mcdonnnj self-assigned this Jan 23, 2023
@mcdonnnj mcdonnnj requested a review from dav3r as a code owner January 23, 2023 17:08
@mcdonnnj mcdonnnj added this to In progress in BOD 18-01 via automation Jan 23, 2023
README.md Outdated Show resolved Hide resolved
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍

BOD 18-01 automation moved this from In progress to Reviewer approved Jan 23, 2023
mcdonnnj and others added 2 commits January 23, 2023 13:22
Since these are acronyms they should be capitalized.

Co-authored-by: dav3r <daver@geekpad.com>
Use consistent spacing and punctuation for all command-line options.
@mcdonnnj mcdonnnj requested review from jsf9k and dav3r January 23, 2023 18:28
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mcdonnnj mcdonnnj merged commit 1ad8975 into develop Jan 23, 2023
BOD 18-01 automation moved this from Reviewer approved to Done Jan 23, 2023
@mcdonnnj mcdonnnj deleted the improvement/update_readme branch January 23, 2023 18:41
cisagovbot pushed a commit that referenced this pull request Apr 26, 2023
…s/setup-go-4

Bump actions/setup-go from 3 to 4
cisagovbot pushed a commit that referenced this pull request Dec 19, 2023
…nore_directives

Add new, disabled dependabot ignore directives
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation This issue or pull request improves or adds to documentation improvement This issue or pull request will add or improve functionality, maintainability, or ease of use
Projects
Status: Done
BOD 18-01
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants