Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add requests to requirements #2

Merged
merged 1 commit into from
May 22, 2020
Merged

Add requests to requirements #2

merged 1 commit into from
May 22, 2020

Conversation

hillaryj
Copy link
Contributor

Adds requests to the required modules and formats the line in setup.py prettier.

πŸ—£ Description

πŸ’­ Motivation and Context

Running the tool requires requests to be installed if it isn't already.

πŸ§ͺ Testing

Run python setup.py install like normal.

πŸš₯ Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (causes existing functionality to change)

βœ… Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@hillaryj hillaryj requested review from dav3r, felddy, jsf9k, mcdonnnj and a team as code owners May 22, 2020 14:05
@hillaryj hillaryj mentioned this pull request May 22, 2020
9 tasks
Copy link
Member

@jsf9k jsf9k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ‘

Do you mind creating an issue in this repo regarding getting coveralls working for forks? Without that it will be more difficult for non-cisagovers to contribute.

@hillaryj
Copy link
Contributor Author

Can do - I went looking in the Github docs and found some info. I'll include this in the issue I open.

With the exception of GITHUB_TOKEN, secrets are not passed to the runner when a workflow is triggered from a forked repository.

https://help.github.com/en/actions/configuring-and-managing-workflows/creating-and-storing-encrypted-secrets

Copy link
Member

@mcdonnnj mcdonnnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense πŸ‘

@jsf9k jsf9k added the bug This issue or pull request addresses broken functionality label May 22, 2020
@hillaryj hillaryj merged commit 4b7888e into develop May 22, 2020
@hillaryj hillaryj deleted the add-requests branch May 22, 2020 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue or pull request addresses broken functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants