Add new options to import IPs/hostnames, and filter IP family output #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is done automatically with the `pre-commit autoupdate` command.
Allows import of lists of static IPs and host names. Add flags to filter IPv4 or IPv6 addresses from output.
felddy
added
the
improvement
jsf9k
reviewed
Jun 23, 2023
| # If there were unresolved hostnames, log an error and terminate the program | ||
| logging.error( | ||
| f"Could not resolve the following hostnames: {', '.join(dns_errors)}" | ||
| ) |
There was a problem hiding this comment.
Do you need to shutdown logging even when you exit uncleanly?
Suggested change
| ) | |
| ) | |
| logging.shutdown() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
This PR adds the ability to include one or more files with lists of IPs and hostnames.
It also adds flags for filtering out IPv4 or IPv6 address from the generated output.
Closes #25
Closes #26
💭 Motivation and context
Features requested by @bra1ncramp in issues:
v4_only=True#26🧪 Testing
Tested on local development machine and in continuous integration.
✅ Pre-approval checklist
to reflect the changes in this PR.