-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove bin/pipeline from repository #12
Labels
question
Further information is requested
Comments
No opposition, that's best practice not only from a weight but also from
release perspective. The binary will not work across OS, Protobuf versions
anyway, therefore when we release a binary we need to tag with it <OS
version, protobuf version> so people are clear on the environment we/CI tested
it.
…On Fri, May 17, 2019 at 5:58 PM Remington Campbell ***@***.***> wrote:
Assigned #12 <#12> to
@repenno <https://github.com/repenno>.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#12?email_source=notifications&email_token=ABTXDJWZ42ALCIOTDFCEOBDPV5IEPA5CNFSM4HNZGOAKYY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGORQOPKBQ#event-2350707974>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABTXDJUZOZR3KZKHHD4CTA3PV5IEPANCNFSM4HNZGOAA>
.
|
Truly closed with our friend https://rtyley.github.io/bfg-repo-cleaner/ |
Yeah, sorry for being late here. We should remove the bin folder from the repo and add binaries to the different releases. It'd would be ideal if we can match the tag for the releases with the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Releasing the pipeline binary in the repository is pretty ugly right now. It carries a pretty large weight 40-60 MB in size. We should instead compile and post binaries in the Releases tab, and rewrite the git history to not include the pipeline binary.
@sbyx or @repenno do you have any opposition to removing the
bin/pipeline
binary?The text was updated successfully, but these errors were encountered: