Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revamp documentation/host on deployment #23

Merged
merged 38 commits into from
Dec 6, 2018
Merged

Revamp documentation/host on deployment #23

merged 38 commits into from
Dec 6, 2018

Conversation

remingtonc
Copy link
Contributor

@remingtonc remingtonc commented Dec 3, 2018 •
edited
Loading

Uses VuePress to do documentation. Hosted at /doc/.
Resolves #20
Resolves #21

@remingtonc remingtonc added enhancement New feature or request documentation Documentation is fun. labels Dec 3, 2018
@remingtonc remingtonc self-assigned this Dec 3, 2018
skkumaravel
skkumaravel reviewed Dec 4, 2018
View reviewed changes
doc/docs/README.md Outdated Show resolved Hide resolved
doc/docs/README.md Outdated Show resolved Hide resolved
ziausyed
ziausyed approved these changes Dec 5, 2018
View reviewed changes
Copy link
Collaborator

@ziausyed ziausyed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Outside of maintaining a consistent voice throughout (which is entirely optional, btw), this is awesome.

doc/README.md Show resolved Hide resolved
doc/docs/dev/architecture/ETL.md Outdated Show resolved Hide resolved
doc/docs/dev/architecture/Web.md Outdated Show resolved Hide resolved
brh55
brh55 reviewed Dec 5, 2018
View reviewed changes
doc/Dockerfile Outdated Show resolved Hide resolved
@ziausyed
Copy link
Collaborator

ziausyed commented Dec 5, 2018

Maybe it would be helpful to have a link to the Github page from the docs?

@remingtonc remingtonc merged commit 631de8e into master Dec 6, 2018
@remingtonc remingtonc deleted the ui-help-mapping-validation branch December 6, 2018 00:55
aishusreeni
aishusreeni reviewed Dec 6, 2018
View reviewed changes
Copy link

@aishusreeni aishusreeni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the image URLs, everything looks great!

doc/docs/README.md Show resolved Hide resolved
doc/docs/dev/architecture/Database.md Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brh55 brh55 brh55 left review comments

@aishusreeni aishusreeni aishusreeni left review comments

@skkumaravel skkumaravel skkumaravel left review comments

@ziausyed ziausyed ziausyed approved these changes

@anushramsurat1 anushramsurat1 Awaiting requested review from anushramsurat1

@rekharawat rekharawat Awaiting requested review from rekharawat

Assignees

@remingtonc remingtonc

Labels
documentation Documentation is fun. enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@remingtonc @ziausyed @brh55 @aishusreeni @skkumaravel