Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ORION-3135: add deletion info in solution status #332

Merged
merged 6 commits into from
Apr 2, 2024

Conversation

bemidji3
Copy link
Contributor

Description

This PR adds support for including info about the solution if it has been deleted in fsoc solution status. In the case where the extensibility:solution object returns 404 when making a GET request, we will check to see if there is an extensibility:solutionDeletion object for the given solutionName and tag. If there is, then we print a helpful message saying that the solution was previously deleted.

Type of Change

  • Bug Fix
  • New Feature
  • Breaking Change
  • Refactor
  • Documentation
  • Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

@codecov-commenter
Copy link

codecov-commenter commented Mar 28, 2024

Codecov Report

Attention: Patch coverage is 0% with 81 lines in your changes are missing coverage. Please review.

Project coverage is 10.31%. Comparing base (00d0c6f) to head (ab78e2d).
Report is 34 commits behind head on main.

Files Patch % Lines
cmd/solution/status.go 0.00% 77 Missing ⚠️
cmd/solution/zap.go 0.00% 4 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #332       +/-   ##
===========================================
- Coverage   26.88%   10.31%   -16.58%     
===========================================
  Files          44      135       +91     
  Lines        4564    10530     +5966     
===========================================
- Hits         1227     1086      -141     
- Misses       3242     9369     +6127     
+ Partials       95       75       -20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pnickolov pnickolov merged commit 4c43161 into cisco-open:main Apr 2, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants