Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for context and quiet mode in platform calls #335

Merged
merged 2 commits into from
Apr 2, 2024

Conversation

pnickolov
Copy link
Contributor

Description

Internal changes in fsoc that allow callers of the platform package to modify the platform API calls they make:

  • specify a go Context (e.g., to control timeouts and cancellations)
  • suppress the progress message and spinner shown during calls

In addition, the spinner is now not even created when stderr is not a terminal. (This should not be a user-visible change, since the spinner package already doesn't show the message if the output is not a terminal.)

Type of Change

  • Bug Fix
  • New Feature
  • Breaking Change
  • Refactor
  • Documentation
  • Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

@pnickolov pnickolov merged commit e37078a into main Apr 2, 2024
3 checks passed
@pnickolov pnickolov deleted the pn/call-context-quiet branch April 2, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant