Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper support for fork + for from directory + solution show #342

Merged
merged 8 commits into from
Apr 16, 2024

Conversation

pnickolov
Copy link
Contributor

Description

Implemented a new internal object to read and keep in memory the full solution, with all its files.

Added solution show command that displays solution's elements: for now, list of files with annotation of their contents (e.g., knowledge vs. object, object type, etc.)

Added support for solution fork from a local directory, as this helps primers/tutorials/workshops and works around the restricted ability to download solutions from other tenants.

Modified the fork capability to not just do global replace (which can inadvertently replace more than necessary and break a solution); instead, it ensures that only values are changed (never keys) and only on word boundary. Additional exceptions are handled, such as renaming the namespace file (which is usually named after the solution name).

Retained the old fork capability for backward compatibility, under a --legacy-replace flag, in case the new algorithm doesn't take care of some cases that are covered in tutorials and workshops.

Type of Change

  • Bug Fix
  • New Feature
  • Breaking Change
  • Refactor
  • Documentation
  • Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

@pnickolov pnickolov marked this pull request as ready for review April 16, 2024 01:46
@pnickolov pnickolov merged commit d8cc22b into main Apr 16, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant