Fix fsoc optimize configure fails if multiple workloads match filter #344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing out inactive entities
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #344 +/- ##
===========================================
- Coverage 26.88% 15.49% -11.39%
===========================================
Files 44 142 +98
Lines 4564 11369 +6805
===========================================
+ Hits 1227 1762 +535
- Misses 3242 9479 +6237
- Partials 95 128 +33 ☔ View full report in Codecov by Sentry. |
pnickolov
previously approved these changes
Apr 12, 2024
- added unit test for covering optimize configure when multiple workloads match but some are inactive - fixed missing log param - fixed should be casting isActive to bool - added test utility SetActiveConfigProfileServer which forwards all api calls to a given url until torn down with returned function
pnickolov
previously approved these changes
Apr 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Try pruning inactive workloads during workload/report search for optimization configure command.
Type of Change
Checklist