Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ORION-3224: use v2beta in path to ks apis and add support for references in fsoc ks get #359

Merged
merged 3 commits into from
May 3, 2024

Conversation

bemidji3
Copy link
Contributor

@bemidji3 bemidji3 commented Apr 22, 2024

Description

This PR contains changes to:

(1) use v2beta in the path to the knowledge store for requests made to the knowledge store (didn't touch any of the optimize command paths, however)
(2) add support for prefetchRefs and prefetchRefsInline query parameters when making get by ID requests (references is only support for get by id at this point)

Type of Change

  • Bug Fix
  • New Feature
  • Breaking Change
  • Refactor
  • Documentation
  • Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

@codecov-commenter
Copy link

codecov-commenter commented Apr 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 20 lines in your changes are missing coverage. Please review.

Project coverage is 15.47%. Comparing base (00d0c6f) to head (3b676f0).
Report is 51 commits behind head on main.

Files Patch % Lines
cmd/knowledge/get.go 0.00% 19 Missing ⚠️
cmd/knowledge/knowledge.go 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #359       +/-   ##
===========================================
- Coverage   26.88%   15.47%   -11.42%     
===========================================
  Files          44      142       +98     
  Lines        4564    11388     +6824     
===========================================
+ Hits         1227     1762      +535     
- Misses       3242     9498     +6256     
- Partials       95      128       +33     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pnickolov pnickolov merged commit f8df160 into cisco-open:main May 3, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants