do not reset forked solution version #376
Conversation
| @@ -215,7 +215,6 @@ func forkFromDisk(sourceDir string, fileSystem afero.Fs, solutionName string, st | |||
| } else { | |||
| solution.Manifest.Name = solutionName | |||
| } | |||
| solution.Manifest.SolutionVersion = "1.0.0" // reset version | |||
There was a problem hiding this comment.
To preserve the prior behavior and the use case of forking examples (where the version reset is the right action), I would recommend adding a flag, e.g., --preserve-solution-version that enables the new behavior explicitly, leaving the default to reset the version (as introduced in ef9a08d)
Also, while the fsoc-supported pseudo-isolation is now deprecated, it is still available if needed for specific uses. It works in a way that is similar to fork, except it is done transparently on solution push and you have control (and the obligation) to identify which instances of the original solution name need to be replaced. The latter is sometimes helpful when the solution name and attribute name element are the same.
|
This change not needed anymore |
Description
Forked solution are means of isolation, and should inherit the original solution version. I.e., when you want to try a new version of the source solution, its new version should be used (right now resets to
1.0.0).Type of Change
Checklist